[D7] Boost Cache Clear

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2643506

Project 2: https://www.drupal.org/node/2640908

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Manual Review:

1. Remove hook_uninstall function in .info file
2. Undefined $enable_bcc variable in module file line no 61. Need to define the variable.

Hi @arunkumark

I just did a review of this module. Please fix the following:

• Remove "version" from the ./boost_cache_clear.info file, it will be added by drupal.org packaging automatically.
• Remove "project" from the ./boost_cache_clear.info file, it will be added by drupal.org packaging automatically.
• Remove "datestamp" from the ./boost_cache_clear.info file, it will be added by drupal.org packaging automatically.

Thanks

That was already reported by the automated review tool, please do a real manual review.

Oh I did not see that. Will do.
I believe the bot only mentioned "Git clone command for the sandbox is missing" issue which @arunkumark has fixed. That's why I did mentioned the pareview report.

Hi. I wanted to test your module, but I am just not getting the tab menu on my content types.

I am getting the configuration menu /admin/config/system/boost-cache-clear

I of course cleared the cache. Am I missing something?

Hi,
File: boost_cache_clear.module
Line number: 160
function boost_cache_clear_by_url() clears all the cached html files for '*' case. This case works fine

/* line 166 */
$end_char = explode("/", $url);

Above code you are splitting the url by'/'. But boost will change the query string value by '_'. So you cant explode by '/'. However this code wont work for sub page caches. That is navigation to inner pages using pager.

For Ex: baseurl/blogs?page=10
Boost will convert as blogs_page=10.html, hence this wont get cleared.
Try to fix it thinking of some pattern matching

Hi,
It should have some validation criteria. When I enter # then it clear cache for home page. Also its not working for nodepages.
Regards
Arvind

Removing review bonus tag, you have not done all manual reviews, you just repeated the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

Good Practice -
There is a module https://www.drupal.org/project/boost_cache_cleaner which does similar what you qwant to provide. you can request to become a maintainer of that module to add the features you are adding here because you are also using same way what the module uses in the hooks event of the boost module.

Git errors:

• Git default branch is not set, see the documentation on setting a default branch.

Manual review:

1. project page: please add the differences to existing modules such as https://www.drupal.org/project/boost_cache_cleaner . Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition. RavindraSingh has already offered you to collaborate on that, so please don't publish yet another module for the same purpose - it only makes it harder for users to find a solution.
2. "; Information added by drupal.org packaging script on 2012-03-21": that line should be removed form the info file. drupal.org will add such a line for packaged downloads later.
3. boost_cache_clear_schema(): what does CCK and CKK mean here? CCK is a Drupal 6 concept and does not exist in Drupal 7?
4. boost_cache_clear_schema(): what is this table used for? Can you add a description to the table?
5. you are using the term CCK throughout the module. That does not exist in Drupal, please use "content type" instead.
6. "watchdog('cron', '%count files removed from boost cache...": you are not the cron module, you should use your own module identifier as first parameter to watchdog().
7. boost_cache_clear_settings_form(): doc block is wrong, this is not hook_form(). See https://www.drupal.org/coding-standards/docs#forms

Otherwise looks good to me. We can still approve your account based on your skill writing this module, I would just ask you to not publish your module and collaborate with RavindraSingh to avoid duplication. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to er.pushpinderrana as he might have time to take a final look at this.

no objections for more than a week, so ...

Thanks for your contribution, Arunkumar!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

@arunkumark: looks like you promoted your module instead of collaborating with RavindraSingh as we discussed? Why the unnecessary duplication?

Congratulation @arunkumark your module is approved by community. Please keep continue with reviewing new project applications for contributing back to the community.

Thanks a lot @Klausi.