Project page - https://www.drupal.org/sandbox/kyvour/2647426

Git clone command:

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/kyvour/2647426.git gsap
cd gsap

This module integrate the GSAP javascript library with Drupal through the Libraries API.

GSAP is a powerful, high-performance javascript animation library for the web.

This module is intended to be an API module for developers.
The main aim is to integrate GSAP with the Libraries API to manage it efficiently as a project dependency.

The similar module GreenSock API is not supporting now. So I wrote another module for GSAP library with better functionality. I read all issues related to GreenSock Api module and implemented requested features in own module. Also my module has api that will be useful for developers who want to define own set of GSAP files without unnecessary (or with additional) GSAP plugins.

Comments

kyvour created an issue. See original summary.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
Issue summary: View changes
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxkyvour2647426git

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
Issue summary: View changes
Status: Needs work » Needs review
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented

All errors reported by automated review tools were fixed.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
Priority: Normal » Major

Can anyone make code review?

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at UniMity Solutions Pvt Limited commented
Status: Needs review » Needs work

Hi kyvour,
On gsap.module file in function gsap_menu() second menu item with URL callback "admin/config/media/gsap/settings" wont have page callback function, if not used please remove this item.

  // gsap.module file gsap_menu() function.
  $items['admin/config/media/gsap/settings'] = array(
    'title' => 'Settings',
    'type' => MENU_DEFAULT_LOCAL_TASK,
  );
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
Status: Needs work » Needs review

Hi arunkumark,

Thank you for your feedback.
I have checked my hook_menu() and removed unnecessary menu item about which you said.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented

Can anyone help with code review?

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
CreditAttribution: anpolimus as a volunteer and at Drupal Ukraine Community commented

I have reviewed this module and approve that its functionality is working properly.

anpolimus’s picture

anpolimus
Primary language Ukrainian
Location Kyiv
CreditAttribution: anpolimus as a volunteer and at Drupal Ukraine Community commented

For future, it would be great if examples of implementation would be added to the Readme and project description.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
Priority: Major » Critical
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
harings_rob’s picture

harings_rob CreditAttribution: harings_rob commented

Hi,

Below are some remaks:

Non blocking:
1. Helper functions should start with an underscore followed by the name of the module.
2. The install hook is not really needed.

I can see the module is well written. I'm putting this to RTBC, but please, as per #12 suggestion: Provide some examples.. maybe a submodule containing an example.

Regards.

harings_rob’s picture

harings_rob CreditAttribution: harings_rob commented
Status: Needs review » Reviewed & tested by the community
kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented

Thanks for your remarks!
As for hook_install() I'm agree with you - it isn't necessary, but I prefer set up variables in hook_install.
I think it's more clearly for other developers to understand what configuration provide this module and i can be sure that all default configs are correct by default.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
mlncn’s picture

mlncn CreditAttribution: mlncn at Agaric commented
Priority: Critical » Normal
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution! Congratulations, you are now a vetted Git user. You can promote this to a full project.

When you create new projects (typically as a sandbox to start) you can then promote them to a full project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

kyvour’s picture

kyvour CreditAttribution: kyvour as a volunteer commented
Status: Fixed » Closed (fixed)