[D7] Media 23Video OAuth

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxbartvig2412809git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Bartvig changed some things based on PAreview, but he is apparently not able to post comments at the moment (for some weird reason). So I'm just helping my coworker by posting this comment at setting status to Need review.

Hello Bartvig,

Automated Review

You seem to still have some errors related to coding standards and your branches. Please review http://pareview.sh/pareview/httpgitdrupalorgsandboxbartvig2412809git and solve these errors.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

No: Does not follow the guidelines for master branch : See pareview review.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

No: Does not follow the guidelines for 3rd party assets/code : you can use a make file for the "23video-for-php" librairy and document it i your readme file (see manualcrop for example).

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template : Add hook_help.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (+) Add configure = admin/config/media/media_23video in info file.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Regards

FILE: /var/www/drupal-7-pareview/pareview_temp/media_23video_oauth.module
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
---------------------------------------------------------------------------
236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
236 | ERROR | [ ] 2 spaces found before inline comment; expected "//
| | dpm($display);" but found "// dpm($display);"

Please don't use random issue tags. That are surely not application blockers, please do a real manual review.

Hi, please check your code in here.
http://pareview.sh/pareview/httpgitdrupalorgsandboxbartvig2412809git
You have a some issues. Thank's.

That minor coding standard errors are surely not application blockers, anything else that you found or should this be RTBC instead? Please do a real manual review.

Hi Bartvig,

Automated Review

There are some minor errors & warnings the automated test reports, see http://pareview.sh/pareview/httpgitdrupalorgsandboxbartvig2412809git-7x-1x

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. There is no need to declare a form element as #type = 'markup', as this is the default type.
2. The doxygen of form functions (form declarations, validation handlers & submission handlers) don't adhere to the documentation standards.
3. The first rule in the media_23video_oauth_admin_form() function defines the $form. This is not necessary.

The comments in the code walkthrough are recommendations.

This review uses the Project Application Review Template.

@bartvig

Manual review suggestions.

1. In line 714 on function media_23video_oauth_sessiontoken_callback(), you checked $fid is set or not instead of check is numeric or not using php function is_numeric().

2. On line 721 function media_23video_oauth_sessiontoken_callback() check is object or not as if(!is_object($file))

3. On function media_23video_oauth_sessiontoken_callback() used one parameter but in hook_menu() page arguments declared as two in array.

Automated Review

The automated review report a couple of warnings and errors: https://pareview.sh/node/1603

Manual Review

Individual user account
Yes: Follows
No duplication
Yes: Follows
Master Branch
Yes: Follows
Licensing
Yes: Follows
3rd party assets/code
Yes: Follows
README.txt/README.md
Yes: Follows
Code long/complex enough for review
Yes: Follows
Secure code
Yes: Follows
Coding style & Drupal API usage

This review uses the Project Application Review Template.

Since I only find some minor warnings reported by PAReview I think this project is RTBC.

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.