This module shows a small block with bitcoin exchange rate cryptocurrency.
Link to sandbox: https://www.drupal.org/sandbox/drupal-developer/2567109
It also shows a tab to calculate Mexican pesos MXN to bitcoin. I have not seen a module of Mexican pesos to Bitcoin
Its use is only recommended for the following currencies MXN, USD, BTC.
For test module use:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/drupal-developer/2567109.git bitapeso_block
cd bitapeso_block
Any questions or support raul@ninja-code.de
http://git.drupal.org/sandbox/drupal-developer/2567109.git
Pledges
For Drupa 8 module, i am start work in 6 months.
If in the future more open currency vs BitCoin? possibly I encouraged me.
Credits
Bitapeso.com / Cesar Gaytan is API Owned.
Paypal
For your donations paypal account:support@hosting-openbsd.info
Help wanted!
Yes, help is always welcome.
Enjoy it
Comment | File | Size | Author |
---|---|---|---|
pesotobitcoin.png | 12.51 KB | kanzer |
Comments
Comment #2
kanzer CreditAttribution: kanzer commentedComment #3
kanzer CreditAttribution: kanzer commentedComment #4
PA robot CreditAttribution: PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdrupal-developer25671...
Fixed the git clone URL in the issue summary for non-maintainer users.
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #5
kanzer CreditAttribution: kanzer commentedComment #6
kanzer CreditAttribution: kanzer commentedComment #7
nitvirus CreditAttribution: nitvirus at Srijan | A Material+ Company commentedHi,
Ran the module through coder:
bitapeso_block.module
severity: normalLine 32: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
severity: normalLine 33: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
severity: normalLine 34: missing space after comma
curl_setopt($ch, CURLOPT_URL,$api);
severity: normalLine 37: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE
$get = json_decode($result, true);
severity: normalLine 40: missing space after comma
'undolar' => round($get['dolar'],2),
Some missing spaces after commas.
Also, try to put a one line break between end of function and starting of new function, it enables easier reading of code.
Comment #8
shams022 CreditAttribution: shams022 commentedGit errors:
Git default branch is not set, see https://www.drupal.org/node/1659588
Comment #9
Sudhakar Dhanapalan CreditAttribution: Sudhakar Dhanapalan at Ameex-Drupal Geeks for Ameex-Drupal Geeks commentedHi,
I reviewed your module and found following issues :
1. I have using Drupal core Jquery library version (1.4) on function is not working. so please change to jquery live function or mention in Readme.txt (Not support to less than 1.6).
2. Please do proper space in (*) Line 30 to 37.
3. Please fix pareview suggestion: http://pareview.sh/pareview/httpgitdrupalorgsandboxdrupal-developer2567109git
Comment #10
arunkumark@kanzer
Manual review suggestions
1. In bitapeso_block_block_info() line 16, you can able to use description, that help to additional details about block.
2. Line 28 Give some Documentation for the your custom function block callback bitapeso_block().
3. In function bitapeso_block() you have used Curl function. Need to use curl time out function. Because when remote server down your application wont affect its failure.
Ex:
curl_setopt($ch, CURLOPT_CONNECTTIMEOUT , TIME_IN_SECOND); // For connection establish.
curl_setopt($ch, CURLOPT_TIMEOUT, TIME_IN_SECOND); // For fetch data.
or use drupal drupal_http_request().
Comment #11
kanzer CreditAttribution: kanzer as a volunteer and commentedthank you for your help
these days to repair the code with advice.
Thank you
Comment #12
NitinSP CreditAttribution: NitinSP at Clarion Technologies commentedManual Review
1. Please use sanitization functions for data that you display from bitapeso service.
2. remove .css & .js file from .info file and only add it where it needed.
3. Please implement hook_help()
4. in bitapeso_block_block_view() you can able to add $block['subject'] that help you for additional details for this block
Comment #13
PA robot CreditAttribution: PA robot commentedClosing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #14
apaderno