[D7] Field Sections

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

You should remove LICENSE.txt from your module - see http://pareview.sh/pareview/httpgitdrupalorgsandboxpshevchuk2503601git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

No: module (admittedly) causes duplication. However, duplication may be justified for performance boosts.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

• README.txt Headings should be in all caps.
• README.txt Headings should be underlined with ===/--- to the length of the heading, followed by a newline.
• README.txt should have an "INTRODUCTION" section rather than a "Summary" section. This section should include link to project page and issue queue.
• README.txt is missing the required "REQUIREMENTS" section
• README.txt CONFIGURATION section should include information about the configuration options

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Line 144: You use '#imput' rather than '#input'.
2. Line 147: Why not simply do '#format' => isset($value['format']) ? $value['format'] : NULL, in the $widget['body'] declaration to mimic what you are doing for the '#default_value'?
3. There are absolutely no in-line comments in your code, only the required "Implements hook_" comments. Commenting your code so others can follow is always a good idea.

This review uses the Project Application Review Template.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2504565

Project 2: https://www.drupal.org/node/2503713

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

@pshevchuk,

This seem unclear to me, how to use your module. In your readme.txt said...

There is no configuration. When enabled, the module will go to admin/structure/types to add or edit Sections fields for your content types.

If I go to admin/structure/types I do not see any different in that page. If you can provide more details about your module, I can do a more deep review on your module and change it to RCTB.

I can confirm that the LICENSE.txt as been remove and fix all the things from comment#3.

@pshevchuk,

Now this make more sense.

• Adding a hook_help to this project would be nice for site builder.
• I think you should add a note to README.txt that said that in order to disable the module the user would have to delete the fields first.
• Pareview.shshow a minor error.
  

  README.txt
  ----------------------------------------------------------------------
  FOUND 1 ERROR AFFECTING 1 LINE
  ----------------------------------------------------------------------
  60 | ERROR | [x] Expected 1 newline at end of file; 2 found

• Coder Module does not show any errors.

None of those point that I mention are blocker, they are just personal recommendation. For this reason, I'm changing to RTBC.

This issue is not fixed since you have not been approved yet? See the workflow: https://www.drupal.org/node/532400

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.