[D7] Simple Meta for Content Types

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxdrubage2484375git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi there,

Modules should remove all variables created by them when uninstalling it.

You can do so easily by implementing hook_uninstall() in a modulename.install file.
Make sure you remove the variables for each content type.

Also, please do not set RTBC status yourself. Usually 3-4 people review your code, set the RTBC status, and then a git admin will pick, inspect and process the application.

Wait for a few others to leave a review.

Hi drubage,

Please put correct link for git clone (You can find the correct git clone command for your sandbox by clicking on the Version control tab, removing the checkbox in front of "Maintainer", and clicking Show. You can then copy-paste the git clone command from the codeblock below "Setting up repository for the first time".).

Automated Review
No pareview errors found

Manual Review

Individual user account
Yes follow the guideline

No duplication
Cant this be done by Metatag module?

Master Branch
Yes follow the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements

The code looks ok, but why you print meta tag directly as string instead of rendering an array in drupal way like:

$data = array(
    '#tag' => 'meta',
    '#attributes' => array(
       'name' => 'description',
       'content' => 'Enter your meta description here.',
    ),
  );
  drupal_add_html_head($data, 'sales_floor_home');

Hi drubage,

Automated Review
No pareview errors found http://pareview.sh/pareview/httpgitdrupalorgsandboxdrubage2484375git

If Metatag is installed it created duplicated Metatag on a page.

Manual Review

Individual user account
Yes follow the guideline

No duplication
No, not a duplicate. This is a Lightweight metatag module where you set Meta tag at content type level and the use Simplemeta for specific paths.

Master Branch
Yes follow the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: Meets the security requirements

This review uses the Project Application Review Template.

Hello,

You git command is wrong when i try to make clone it was giving permission issue.
I think your git command should be

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/drubage/2484375.git simple_meta_for_content_types

Because when i try with this command i get downloaded successfully.
So please change the git command.

Thanks

Hello

You have used hook_form_FORM_ID_alter function. But the arguments of this function is not proper you have taken simplemeta_content_types_form_node_type_form_alter(&$form, $form_state).

But it should be simplemeta_content_types_form_node_type_form_alter(&$form, &$form_state, $form_id) {.

From comparing you can see you have missed & in the $form_state argument as well as you have not taken third parameter $form_id.
See the api - https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

Thanks

Hello

Use hook_help for the user to make help in understanding the project from the admin UI.

Thanks

We generally frown on RTBC'ing your own project application, however, I've given this another look and I think it's fine.

Thanks for your contribution!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.