[D7] Replicate User

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi vbouchet,

1) Your Git clone URL is imporper. i think it should be this.

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/vtriclot/2452305.git replicate_user

2) Pareview is generating some errors.

Kindly correct them.

I've fixed the git URL. Pareview errors are false positives as Vincent explained in the OP.

Pareview result is available here. (2 warnings about undefined variables are false positive as the purpose if these 2 lines are to test if these variables are defined)

Reviewing.

I attempted to review this, but with Replicate User, Replicate and Replicate UI turned on, I don't get a Replicate tab on the user so I can't test. Is there more to this?

I think we might need to add the following patch @vbouchet.

Hi vbouchet,

nice module, why don't you apply the patch provided y tephonius in comment #3?

Pareview.sh show some CodeSniffer errors http://pareview.sh/pareview/httpgitdrupalorgsandboxvtriclot2452305git

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[Yes: Does not cause] module duplication and/or fragmentation.
Extend Replication Module
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[Yes: Follows] the the guidelines for in-project documentation.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
I haven't done any security review
Coding style & Drupal API usage
Please fix all of the code style issues reported by pareview.sh

FILE: /var/www/drupal-7-pareview/pareview_temp/replicate_user.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
78 | WARNING | Variable $username is undefined.
162 | WARNING | Variable $mail is undefined.
----------------------------------------------------------------------

This review uses the Project Application Review Template.

Oops, my bad - I completely forgot that - @vbouchet is right!

This is a useful module. I will certainly use it to build test accounts with similar names, fake email addresses, and identical roles. Because it uses entity replication, custom fields are automatically included in the replication.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

1. While the README.txt file contains the necessary information, the guidelines say it should follow the README template. Modules that follow the standard template are easier for site builders to install.
2. The README.txt file should state that Replicate UI module versions 1.4 and earlier do not work with this module. The 1.x-dev version dated 2015-Mar-12 does work with this module.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

[List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) Email addresses must be unique for user entities to be saved by the User module. The replicate process implemented here permits the entity to be saved with a duplicate email address. The login process for forgotten password allows the user to provide only an email address. If the email address is a duplicate, the email is sent for the original username regardless of which user name had been desired. If any changes are desired, the email address must be changed before they can be saved. The email address must be changed to cancel the account. The code should require the email address to be updated.
2. The title on the verification uses only the user ID field. It would be helpful to use the username instead. (I recognize that this may not be easy or even possible. Alternately, there could already be a hook from the replicate API.)

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Thanks for submitting the application.
I will do a manual review tonight but I read the code in git viewer - really well-written.

A few points, which all of them are minor:

- When linking to modules, use https.
- in the admin for, instead of doing a #default_value = 1, you can use variable_get()'s second parameter to return 1 as the default value. That way, submitting the form does not overwrite any previously-set variables.

manual review:

• replicate_user.test: "@inheritdoc" should be "{@inheritdoc}", see https://www.drupal.org/coding-standards/docs#inheritdoc

Otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to Naveen as he might have time to take a final look at this.

Review of the 7.x-1.x branch (commit f2dba31):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: .../www/d7/sites/all/modules/contrib/pareview_temp/replicate_user.module
  ---------------------------------------------------------------------------
  FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
  ---------------------------------------------------------------------------
    78 | WARNING | Variable $username is undefined.
   162 | WARNING | Variable $mail is undefined.
  ---------------------------------------------------------------------------
  
  Time: 148ms; Memory: 6Mb
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...w/d7/sites/all/modules/contrib/pareview_temp/replicate_user.admin.inc
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 188 | ERROR | Type hint "array" missing for $element
---------------------------------------------------------------------------


FILE: ...cs/www/d7/sites/all/modules/contrib/pareview_temp/replicate_user.test
---------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
---------------------------------------------------------------------------
   9 | ERROR | [x] Doc comment short description must end with a full stop
  15 | ERROR | [ ] Missing short description in doc comment
  26 | ERROR | [ ] Missing short description in doc comment
 124 | ERROR | [x] Doc comment short description must end with a full stop
 130 | ERROR | [ ] Missing short description in doc comment
 141 | ERROR | [ ] Missing short description in doc comment
 218 | ERROR | [x] The closing brace for the class must have an empty line
     |       |     before it
 221 | ERROR | [x] Doc comment short description must end with a full stop
 227 | ERROR | [ ] Missing short description in doc comment
 238 | ERROR | [ ] Missing short description in doc comment
 259 | ERROR | [x] The closing brace for the class must have an empty line
     |       |     before it
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

Time: 349ms; Memory: 8Mb

Manual Review :

1. The code is well written. replicate_user_help : When linking to modules on drupal.org append www to the urls as well.
2. Address #25
3. The module is fully relying on the user module.So add a hard dependency on the user module in replicate_user.info .The replicate module is is also not dependent on user module.

Thanks for your contribution, vbouchet!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.