[D7] Views Slideshow Rendered Entity Pager [#2423079]

Description

This module extends the Views Slideshow pager functionality to provide a new widget to display rendered entities in the pager (instead of simple bullet for example). You can select a specific view mode to be used in the pager.

Development of this module has been based on Views Slideshow Simple Pager which is providing another pager widget to display item numbers.

Usefull links

Project page is available here.
Pareview result is available here.
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/vtriclot/2422491.git views_slideshow_rendered_entity_pager

Simpletest.me

Sandbox can be created using the following link.
Enable Views UI.
Create 2 articles.
Create a new View using the "Slideshow" format and displaying "Articles" with "Teaser" view mode.
Edit the format settings.
In Top or Bottom widgets, check the "Pager" checkbox.
Select "Rendered Entity" in "Pager type" select list.
Select "Search Result" view mode in "Pager view mode" select list.
Save the views and see the new carousel.

Manual reviews of other projects

Comment	File	Size	Author
#2	slideshow.png	30.61 KB	sajiniantony

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

PA robot CreditAttribution: PA robot commented 9 February 2015 at 23:23

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #2

sajiniantony CreditAttribution: sajiniantony commented 10 February 2015 at 06:52

File	Size
slideshow.png	30.61 KB

Hi,
I downloaded and installed this module and got the below issue.

Issue
======
1.Create a view displaying items in the format Slideshow.
2. I got the below notice of undefined index in the file views_slideshow_rendered_entity_pager.module.
See attached slideshow.png

Comment #3

sajiniantony CreditAttribution: sajiniantony commented 10 February 2015 at 07:41

Status:

Needs review

» Needs work

Comment #4

vbouchet

Toulouse

CreditAttribution: vbouchet commented 10 February 2015 at 08:15

Status:

Needs work

» Needs review

Hi,
Thanks for the feedback.

See this commit fixing the notice.

Comment #5

yuriy.kostin CreditAttribution: yuriy.kostin commented 10 February 2015 at 10:58

Status:

Needs review

» Needs work

Hi Sajiniantony,

Automated Review
☑ Yes

Individual user account
☑ Follows the guidelines for individual user accounts.

Master Branch
☑ Yes

README.txt/README.md
✎ Please complete your README file content with README template https://www.drupal.org/node/2181737

Project Description
The git command is wrong,
git clone --branch 7.x-1.x vtriclot@git.drupal.org:sandbox/vtriclot/2422491.git views_slideshow_rendered_entity_pager
should be instead
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/vtriclot/2422491.git views_slideshow_rendered_entity_pager

Comment #6

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 10 February 2015 at 11:02

Status:

Needs work

» Needs review

The wrong git command and README improvements are surely not application blockers, anything else that you found or should this be RTBC instead?

Comment #7

vbouchet

Toulouse

CreditAttribution: vbouchet commented 10 February 2015 at 13:04

Issue summary:

View changes

Hi,
I updated the git command.

The README.txt file has been updated in the following commit.

Thanks,

Comment #8

naveenvalecha

He/Him

Hindi

CreditAttribution: naveenvalecha commented 15 February 2015 at 02:20

I would recommend you, please help to review other project applications to get a review bonus back. This will put you on the high priority list, then git administrators will take a look at your project right away :)

Comment #9

vbouchet

Toulouse

CreditAttribution: vbouchet commented 17 February 2015 at 21:00

Issue summary:

View changes

Comment #10

vbouchet

Toulouse

CreditAttribution: vbouchet commented 17 February 2015 at 21:34

Issue summary:

View changes

Comment #11

vbouchet

Toulouse

CreditAttribution: vbouchet commented 17 February 2015 at 22:32

Issue summary:	View changes
Issue tags:		+PAreview: review bonus

Comment #12

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 22 February 2015 at 23:14

Assigned:	Unassigned	» heddn
Status:	Needs review	» Reviewed & tested by the community
Issue tags:	-PAreview: review bonus	+PAreview: single application approval

Review of the 7.x-1.x branch (commit b8c4534):

Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

FILE: /home/klausi/pareview_temp/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 83 characters
  4 | WARNING | Line exceeds 80 characters; contains 81 characters
 27 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

Otherwise looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to heddn as he might have time to take a final look at this.

Comment #13

vbouchet

Toulouse

CreditAttribution: vbouchet commented 23 February 2015 at 08:37

Hi Klausi,

I updated the readme.txt to fix the 3 warnings.

Regarding the git approval process, I really think it should be updated. I don't understand why a dev can push how many modules he wants as soon as one if his module has been approved. I will try to discuss it on the thread you point me.

However, I'm of course agree for a single project promote. This module will remain simple, it's only a plugin for another module and there is no reason to add functions and code only to match minimum requirements.

Thanks,

Comment #14

heddn

English

Nicaragua

CreditAttribution: heddn commented 2 March 2015 at 13:33

Status:

Reviewed & tested by the community

» Fixed

No issues with the security of the project. Congratulations vbouchet,
this has been promoted to a full project. Now that this experimental project has been promoted, you'll need to update the URL of your remote repository or reclone it.

Comment #15

klausi

he/him||they/them

German

🇦🇹 Vienna

CreditAttribution: klausi commented 2 March 2015 at 21:04

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.