Remove the word "custom" from block module UI elements

I think this can be marked a duplicate of #1920862: Rename custom_block.module to block_content.module, as "Custom Block" module will become "Block Content" module.

#1920862: Rename custom_block.module to block_content.module decided to leave the decisions about rewording to a follow up so this looks to me like it should still be active. "custom block" seems somehow out of place now. I feel having only "Block types" might be confusing though as they are separate from other kinds of blocks and there will be block types not visible on that list. An alternative could be having "Content block types".

working on it...

Switched "Add custom block" to "Add block".

Attached a new patch.

Some tests relied on a button text with the word 'custom'.

Works for me

Path #8 is now broken because of #2291137.
I recreated the patch against the current DEV.

To me it seems that if the terms used are identical for both user created block types and all the others, it could be an usability issue. After all the custom blocks will be completely defined by the user but they can't do much about the other ones.

Looks like current patch may also not get rid of the "custom block" terminology everywhere as I think we'd still have the "Custom block library" tab and the category "Custom" for these blocks.

This is #11 patch rerolled (or similar)

This patch does work for the button "Add custom block type" (see the original picture).

According to the original post, it looks like Drupal core has changed the link text from "Custom block types" to "Custom block library". Is the current link text supposed to replace the word "Custom" as well? I mark this patch as "Needs work" since it's a question needs to be answered first.

From DrupalCon 2015 LA.

Can't find where to change page title, see 2015-06-18_1253.png

Re-rolling the patch which is in #18 with some modification. Also attaching interdiff

Still can't find where to change title, see image in my comment #21

What: checked for appearance on "custom" word.
Result: Missing title(when block library is selected), custom word is still appearing.
Status: Needs Work!

"custom" word deleted, but for disappearing title - can't reproduce, for me title is present and still i can't find a place where to change it (see image in #21)

Note: The block UI is currently changed as part of #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block

Removing srijansprintnight tag!! :)

What: checked for the appearance on "custom" word.
Browser: Chrome on Linux.
Result: Missing title(when block library is selected). Screenshot attached
Status: Needs Review

Needs re-roll

Patch rerolled
@hitesh-jain : Hope I didn't take your job!

The renaming was done for the "add block"-button but not for the "page title".
But maybe this is a caching issue in my dev as it locks o.k. in the module files.

Also the navigation item "custom block types" has been removed meanwhile from the left navigation into a tab "Block Library".

Example image:

Can anyone else please test it if the remaining issues is maybe a cache problem within my dev.

I have found some other text strings where still "custom block(s)" is mentioned but not the title we want to change.
Also it looks that on this page the code structure is different from the other pages and maybe "breaks" (wrong spelled in the pic) the layout.

Please see:

Finally I think the patch is ok, but the issue needs additional work.

In #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block it was determined that it was more important to remove "library" from the label.

However, this was not helpful either, because it's actually a list of only your custom blocks, *not* a "library" of anything. I think the quote from one participant was something like, "Custom block library listing, now we're talking! ...Wait. I thought you said you had a block library?!"

We cannot remove both "custom" and "library" from the label. I think many users find "custom blocks" to be synonymous to "block content" as well (for example, even the help page for the module is under "Custom block"). Additionally, #2523154: Improve workflow for creating custom blocks also changes the workflow, menu structure, and labels of custom block pages, so that many instances of "custom blocks" become "block content" or "block types".

Therefore this issue should at a minimum be postponed on #2523154 and used to clean up any remaining references to "custom block" if there is a need for that. Otherwise it should be closed.

Closing out as outdated as there hasn't been movement since being postponed 7 years ago. I agree with the comment in #54

We cannot remove both "custom" and "library" from the label. I think many users find "custom blocks" to be synonymous to "block content"

If anyone still feel this is an issue please reopen to justify why.