Problem/Motivation
Due to changes made in #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block the previous action link for creating custom blocks was moved. This however made creating custom blocks non-obvious and the workflow for creating one somewhat convoluted.
The current workflow and UI state (courtesy of larowlan in #233):
- Visit block layout
- Click place block next to a region (modal)
- Click add custom block action link (modal)
- Redirect to block/add (non modal)
- Add custom block content entity (non modal)
- Redirect to place block form (non modal)
- Save block placement
- Redirect to block layout, new block highlighted
Note: The buttons on the current page were renamed to "Place block" solely because of the current action button (see #214), so it could also be changed back to "Add block" if it were to be removed.
Proposed resolution
Place the management of custom block content under /admin/content to achieve the following workflow which effectively cuts the number of required steps in half and makes more sense from a content manager's perspective.
- Visit Custom blocks (currently Custom block library)
- Click add custom block action link
- Save block
- Redirect to Custom blocks
Place the management of custom block types under /admin/structure to achieve the following workflow which reduces the number of required steps by two and makes more sense from a site-builder's perspective.
- Visit Block types
- Click add custom block type action link
- Save block type
- Redirect to Block types
Remaining tasks
Review
Commit
User interface changes
Relocation of two block_content related sections.
API changes
None.
Data model changes
None.
Beta phase evaluation
| Issue category | Task: Affects usability; not a bug. |
|---|---|
| Issue priority | Major: Significant regression in user experience (may be critical at core maintainers' discretion). Very high probability that user's will not find module functionality. |
| Prioritized changes | Yes: Usability and UX improvement. Follow-up to recent critical. |
| Disruption | Undetermined, but likely minimal. Unlikely to require changes in contributed modules. No widespread changes. No subsystem changes. No data alteration. |
| Comment | File | Size | Author |
|---|---|---|---|
| #31 | 2523154-31.patch | 34.94 KB | MattA |
Comments
Comment #1
legolasboComment #2
MattA commentedMoving proposals to comments until we get more consensus.
Current options are:
Comment #3
legolasboThis would still leave the "Custom blocks" tab in a really unexpected position on the "Block layout" page since there are no custom_block related actions on that page. I propose moving the tab to the "Add block to layout page" aswel. See attached mockups.
Custom blocks tab removed.

Custom blocks tab added.

Comment #4
MattA commentedHmm, the main drawback with option 2 is from the clicks involved with going through the menu system.
So starting from the home page we get:
Almost right off the bat the workflow takes a weird turn. Why would a new user go to block layout when they want to create a new block? Placement is irrelevant to what they are trying to do. They know it doesn't exist, and therefore cannot be placed. Adding that third click is kind of just pouring salt into the wound.
Maybe we could add it directly to the 'Structure' menu, or even split custom blocks and custom block types. Moving the first to the 'admin/content' path and the second to the 'admin/structure' path?
Comment #5
MattA commentedSigh. You wanna know how old this issue really is?
#1164718: Improving the usability between "custom block" and "content"
Comment #6
MattA commentedSo I read through the issue above, and we kind of need a maintainer to decide how to proceed.
Using the options mentioned in #43:
Incidentally, that issue also contains our solution:
...means we should almost certainly create something in 'admin/content' heh.
Comment #7
MattA commentedAdded beta phase evaluation.
Comment #8
larowlanUntil #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block is in I think it makes sense to postpone this
Comment #9
larowlanBlocker is in, thanks everyone for their work so far
Comment #10
naheemsays commentedCould changed wording help improve the issues being addressed?
add custom block >> create new block,
add block/place block >> place existing block
Comment #11
MattA commentedUpdated the IS, issue category, and beta evaluation since #2512456: Implement the new block layout design to emphasize the primary interaction of placing a block was changed to bring back the old action button.
#10 I don't see how. The primary concern is that the clicks involved are buried in menus and/or other unrelated tasks. The updated issue summary has a complete list of required actions, including their modal/non-modal display state, that shows how absurd it is in practice.
Comment #12
legolasboI've also had a look at the current workflow for creating custom block types, which is the following:
As @MattA suggested in #4 the current workflow is taking a strange/unexpected turn for both the creation of a custom block and custom block type. By splitting whats currently called the "Custom block library" in two and repositioning the management of both custom blocks and custom block types we could greatly simplify the workflow for both and be more in line with the workflow used throughout core. My suggested approach is the following:
/admin/contentto achieve the following workflow which effectively cuts the number of required steps in half and makes more sense from a content manager's perspective./admin/structureto achieve the following workflow which reduces the number of required steps by two and makes more sense from a site-builder's perspective.Comment #13
MattA commentedYep, I fully concur with @legolasbo.
I was toying around with it and moved the entire tab to 'admin/content' which would make a lot more sense to normal users. Ideally, Drupal would use a task-based approach to it's menu structure (best for users), instead of categorizing it (which let's be honest, doesn't even work well for developers/site-builders half the time). If that were the case, leaving the 'types' sub-tab there would be ideal, but since it is not, splitting it off to 'Structure' brings it inline with the current menu system.
Comment #14
legolasboAttached patch implements the changes suggested in #12 and contains updated tests aswel.
Comment #15
legolasboOops, forgot to attach the patch
Comment #17
legolasboConfigTranslationListUiTest.BlockContentLocalTasksTest.phpbecause the local tasks it tests have been removed.Comment #18
MattA commentedComment #19
MattA commentedAlso wanted to add that I'm not a fan of the 'admin/structure/block-content' path, but it looks like there's already a separate issue that would fix it: #2501691: Change content-types, comment-types, and block-types URLs.
Comment #21
MattA commentedTest fix.
Comment #22
MattA commentedComment #23
MattA commentedJust a quick rebase (no actual changes) since #2541416: Block content view is missing the 'default' tag. changed an unrelated line that prevented the previous patch from applying cleanly.
Comment #26
MattA commentedRerolled. Basically just updated !placeholders to :placeholders and some test updates.
Comment #27
MattA commentedTwo documentation changes, one to prevent a regression from #2493475: Fix online docs references in Help to conform to our standards and another because if we did this right, content authors shouldn't have to know about the underlying fields and stuff.
Comment #28
Bojhan commentedWhat needs review here? Feel free to add it again.
Comment #29
MattA commentedSince a lot of the pages were moved around, the question was essentially if people would be able to find the right pages for their task and if the workflow was actually better. Although, since the actual forms and UI of the pages has not changed (except for the button in the modal dialog that was removed) I guess this could technically just need a product manager review?
Comment #30
Bojhan commentedNope, this would be perfect for UX review - can you reroll the patch, so I can try it?
Comment #31
MattA commentedComment #32
Bojhan commentedThis actually matches exactly what we set out to do, so I think this simply needs code review in order to go in.
Comment #34
yoroy commentedComment #36
larowlanCode looks good but it does make a major change to UX - want to be sure that UX folks are happy with this.
This breaks adding a block content entity and a placement in one step. Not sure we want to do that - UX folks?
So we're removing this from the 'Place block' dialog. This will mean you can no longer add and place a block in one step. Are we happy with this? UX folks?
Comment #37
cilefen commentedIs this a regression? The current behavior is different than "current workflow" in the issue summary.
Comment #40
suldan commentedThe redirect to the block placement UI after saving a new custom block is still confusing. People may think the placement is required. When you are creating multiple blocks for Panelizer or Page Manager this results in a odd workflow.
Why not redirect to the custom block library and add an operation 'place block'.
Comment #50
smustgrave commentedWonder if this is still relevant after https://www.drupal.org/project/drupal/issues/2833116 is committed?
Comment #52
benjifisherPart of the proposed resolution for this issue agrees with the aim of some other issues:
So I am making this issue a child of the newly created #3318110: [meta] Reorganize Block items in the administration menu in order to group it with related issues.
I am making the previous parent issue a related one: #2497361: [meta] Fix issues found during UMN Usability Testing 2015.
Comment #53
smustgrave commentedClosing this a duplicate now that the block library has moved to admin/content and block types are moved to under structure. Will move credit over to https://www.drupal.org/project/drupal/issues/2862564