Problem/Motivation

Comment types are managed at :
/admin/structure/comment
and edited at
/admin/structure/comment/manage/[xxx]
This feels wrong as a user because it is not about a single comment but about comment-types in general, thus comment in url should be change to comment-types.

Content types are managed at :
/admin/structure/types
and edited at
/admin/structure/types/manage/[xxx]
This feels wrong as a user because it is about node types. Types is to vague : node types ? comment types ? Thus types in url should be change to node-types.

Block types are managed at :
/admin/structure/block/block-content
and edited at
/admin/structure/block/block-content/manage/[xxx]
This feels wrong as a user because it is about blocks types. We have the concepts of types for content and comments, and here we use block-content concept for what is basically a block type. Thus block_content in url should be change to block-types since this actually maintain homogeneity in concepts.

Proposed resolution

Change URLs as following :

For content-types :

  • /admin/structure/types to /admin/structure/content-types
  • /admin/structure/types/add to /admin/structure/content-types/add
  • /admin/structure/types/manage/{node_type} to /admin/structure/content-types/manage/{node_type}
  • /admin/structure/types/manage/{node_type}/delete to /admin/structure/content-types/manage/{node_type}/delete

For comment-types :

  • /admin/structure/comment to /admin/structure/comment-types
  • /admin/structure/comment/types/add to /admin/structure/comment-types/add
  • /admin/structure/comment/manage/{node_type} to /admin/structure/comment-types/manage/{comment_type}
  • /admin/structure/comment/manage/{node_type}/delete to /admin/structure/comment-types/manage/{comment_type}/delete

For block-types :

  • /admin/structure/block/block-content/types to /admin/structure/block-types
  • /admin/structure/block/block-content/types/add to /admin/structure/block-types/add
  • /admin/structure/block/block-content/manage/{block_content_type} to /admin/structure/block-types/manage/{block_content_type}
  • /admin/structure/block/block-content/manage/{block_content_type}/delete to /admin/structure/block-types/manage/{block_content_type}/delete

Remaining tasks

  • The issue needs a usability signoff.
  • Discuss the positive impact of this change vs. breaking existing links that do not use routes (e.g. in content and maybe other cases).
Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Update the issue summary noting if allowed during the beta Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

User interface changes

None apart from URLs.

API changes

None

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because it is about improving URLs consistancy along Drupal Core.
Issue priority Normal because it is renaming of URLs, thus has isolated impact.
Prioritized changes The main goal of this issue is usability and accessibility because URLs would be more consistent for a user.
Disruption Should not be disruptive more contributed modules unless they uses the URLs for WebBase tests as Simplify module does. Disruptive for existing sites if these have existing links for these paths that do not use routes (e.g. in content fields and maybe other cases).
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dom.’s picture

Status: Active » Needs review
FileSize
146.35 KB

Status: Needs review » Needs work

The last submitted patch, 1: normalize-per-types-urls--2501691-1.patch, failed testing.

Dom.’s picture

Should be better this time.

Dom.’s picture

Status: Needs work » Needs review
Dom.’s picture

Title: Change node_type and content_type manage URLs » Change content-types and comment-types URLs
Dom.’s picture

Issue tags: +php-novice, +Novice
YesCT’s picture

Issue summary: View changes
Issue tags: +Needs issue summary update

since this is a normal task, let's get a beta evaluation on this to see if it is an allowed change.
https://www.drupal.org/contributor-tasks/update-allowed-beta

Dom.’s picture

Issue summary: View changes
Dom.’s picture

Issue summary: View changes
cbanman’s picture

Status: Needs review » Reviewed & tested by the community

Patch RTBC:

- reviewed code
- checked URLs for content-types pre-patch
- checked URLs for comment-types pre-patch
- applied patch
- confirmed changes in URLs for content-types post-patch
- confirmed changes in URLs for comment-types post-patch

Everything appears to be working as intended.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: normalize-per-types-urls--2501691-3.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: normalize-per-types-urls--2501691-3.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: normalize-per-types-urls--2501691-3.patch, failed testing.

Dom.’s picture

Status: Needs work » Needs review
FileSize
102.84 KB
1.16 KB
Manjit.Singh’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Novice
FileSize
89.41 KB
89.94 KB
90.49 KB
96.47 KB
90.65 KB
89.39 KB

manually test #16 patch.

URL changes to

  • /admin/structure/types to /admin/structure/content-types
  • /admin/structure/types/add to /admin/structure/content-types/add
  • /admin/structure/types/manage/{node_type} to /admin/structure/content-types/manage/{node_type}
  • /admin/structure/types/manage/{node_type}/delete to /admin/structure/content-types/manage/{node_type}/delete

There are some screenshots after applied patch. Please have a look into it.

Before

content-types

After

content-types

content-types

content-types

content-types

content-types

larowlan’s picture

Makes sense to me

xjm’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs usability review, +Needs product manager review

Thanks for the screenshots and the beta evaluation!

I definitely see the case for this change. However, I think the disruption documented in the beta evaluation is not complete. We also need to look at the impact on existing sites, which may sometimes hardcode paths in links in content fields, e.g. <a href="/admin/structure/blah"></a>, and weigh the disruption against the benefit of making the change. Broken links are a reasonably easy thing to fix, many sites run reports for them, and as admin paths they're less likely to be linked all over in content, but it is still a disruption. (I'm also not sure about this, but it could potentially break some custom views stuff maybe, since IIRC views might rely on paths instead of routes in the UI in some places. etc. Worth double-checking, at least.)

Since these paths are also a reasonably important and commonly used part of our IA, I think it would also be good to have a usability maintainer signoff, so tagging for that. (We already have a comment maintainer signoff from larowlan.) Also tentatively tagging for product manager goodness (it's not a hugely significant change product-wise, but we can always assign to @webchick for a looksee if we RTBC it again after discussing).

I've updated the remaining tasks section of the summary and the beta evaluation to reflect my remarks here.

Dom.’s picture

Added block types in the loop : those also have even weirder URLs plus as named block-content which seems a duplicate notion from block-types (see updated issue description).

Dom.’s picture

Title: Change content-types and comment-types URLs » Change content-types, comment-types and block-types URLs

Status: Needs review » Needs work

The last submitted patch, 20: normalize-per-types-urls--2501691-20.patch, failed testing.

andypost’s picture

Dom.’s picture

Status: Needs work » Needs review
FileSize
6.93 KB

I mixed things up between /admin/structure/block/block-content and /admin/structure/block/block-content/types. This patch corrects it.

Regarding @andypost #23, what does it imply, what should I do thus as a following work ?

andypost’s picture

@Dom. At least to check other entities (aggregator, taxonomy) and their paths, I'm sure that changing a weight of menu items should be separate issue

Status: Needs review » Needs work

The last submitted patch, 24: normalize-per-types-urls--2501691-24.patch, failed testing.

anavarre’s picture

Issue tags: +Needs reroll
Manjit.Singh’s picture

Manjit.Singh’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 29: normalize-per-types-urls--2501691-29.patch, failed testing.

The last submitted patch, 29: normalize-per-types-urls--2501691-29.patch, failed testing.

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 29: normalize-per-types-urls--2501691-29.patch, failed testing.

Bojhan’s picture

Issue tags: -Needs usability review

This makes sense we now have too much "types" and by consistently prefixing them with the "type" of content this refers to we should make it more understandable where the given entity is related to. Thanks for flagging this.

xjm’s picture

Title: Change content-types, comment-types and block-types URLs » Change content-types, comment-types, and block-types URLs
Version: 8.0.x-dev » 8.1.x-dev
Issue summary: View changes
Issue tags: -Needs product manager review

Thanks @Bojhan!

Since this involves changes to the information architecture and would be disruptive for existing sites because it could break links, moving to 8.1.x.

xjm’s picture

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

geerlingguy’s picture

As part of this issue, can we also add a link to 'Block types' after 'Block layout'? It's quite unintuitive to go to the admin/structure page to manage 'Content types' and 'Comment types', but then I have to go to 'Block layout', then 'Custom block library' to finally find a text link over to the 'Custom block types' admin page :/

Revathi.B’s picture

FileSize
138.13 KB

I have to change all the files which are using that path or URL even the test files also I have to change the URL.Because of URL should not be conflict.

geerlingguy’s picture

This patch has a lot of commented code...

Revathi.B’s picture

Sonal.Sangale’s picture

Assigned: Unassigned » Sonal.Sangale
Sonal.Sangale’s picture

Status: Needs work » Needs review
FileSize
4.07 KB
3.85 KB

Removed the commented code.

Status: Needs review » Needs work

The last submitted patch, 44: 2501691-44.patch, failed testing.

Sonal.Sangale’s picture

Assigned: Sonal.Sangale » Unassigned
Manjit.Singh’s picture

anybody have any idea why it is failing ?

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

rajeshwari10’s picture

Assigned: Unassigned » rajeshwari10
rajeshwari10’s picture

Assigned: rajeshwari10 » Unassigned
Status: Needs work » Needs review
FileSize
125.54 KB

I have changed the Content type, comment and blocks url according to Proposed Solution for 8.4.x branch

Please Review.

Thanks!!

Status: Needs review » Needs work

The last submitted patch, 51: 2501691-51.patch, failed testing. View results

rajeshwari10’s picture

Status: Needs work » Needs review
FileSize
140.41 KB

Status: Needs review » Needs work

The last submitted patch, 53: 2501691-53.patch, failed testing. View results

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Ivan Berezhnov’s picture

Issue tags: +CSKyiv18

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Sonal.Sangale’s picture

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.