Problem/Motivation
Comment types are managed at :
/admin/structure/comment
and edited at
/admin/structure/comment/manage/[xxx]
This feels wrong as a user because it is not about a single comment but about comment-types in general, thus comment in url should be change to comment-types.
Content types are managed at :
/admin/structure/types
and edited at
/admin/structure/types/manage/[xxx]
This feels wrong as a user because it is about node types. Types is to vague : node types ? comment types ? Thus types in url should be change to node-types.
Block types are managed at :
/admin/structure/block/block-content
and edited at
/admin/structure/block/block-content/manage/[xxx]
This feels wrong as a user because it is about blocks types. We have the concepts of types for content and comments, and here we use block-content concept for what is basically a block type. Thus block_content in url should be change to block-types since this actually maintain homogeneity in concepts.
Proposed resolution
Change URLs as following :
For content-types :
- /admin/structure/types to /admin/structure/content-types
- /admin/structure/types/add to /admin/structure/content-types/add
- /admin/structure/types/manage/{node_type} to /admin/structure/content-types/manage/{node_type}
- /admin/structure/types/manage/{node_type}/delete to /admin/structure/content-types/manage/{node_type}/delete
For comment-types :
- /admin/structure/comment to /admin/structure/comment-types
- /admin/structure/comment/types/add to /admin/structure/comment-types/add
- /admin/structure/comment/manage/{node_type} to /admin/structure/comment-types/manage/{comment_type}
- /admin/structure/comment/manage/{node_type}/delete to /admin/structure/comment-types/manage/{comment_type}/delete
For block-types :
- /admin/structure/block/block-content/types to /admin/structure/block-types
- /admin/structure/block/block-content/types/add to /admin/structure/block-types/add
- /admin/structure/block/block-content/manage/{block_content_type} to /admin/structure/block-types/manage/{block_content_type}
- /admin/structure/block/block-content/manage/{block_content_type}/delete to /admin/structure/block-types/manage/{block_content_type}/delete
Remaining tasks
- The issue needs a usability signoff.
- Discuss the positive impact of this change vs. breaking existing links that do not use routes (e.g. in content and maybe other cases).
Task | Novice task? | Contributor instructions | Complete? |
---|---|---|---|
Instructions | |||
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards | Instructions |
User interface changes
None apart from URLs.
API changes
None
Issue category | Task because it is about improving URLs consistancy along Drupal Core. |
---|---|
Issue priority | Normal because it is renaming of URLs, thus has isolated impact. |
Prioritized changes | The main goal of this issue is usability and accessibility because URLs would be more consistent for a user. |
Disruption | Should not be disruptive more contributed modules unless they uses the URLs for WebBase tests as Simplify module does. Disruptive for existing sites if these have existing links for these paths that do not use routes (e.g. in content fields and maybe other cases). |
Comment | File | Size | Author |
---|---|---|---|
#53 | 2501691-53.patch | 140.41 KB | rajeshwari10 |
#51 | 2501691-51.patch | 125.54 KB | rajeshwari10 |
#44 | interdiff-2501691-42-44.txt | 3.85 KB | Sonal.Sangale |
#44 | 2501691-44.patch | 4.07 KB | Sonal.Sangale |
#42 | normalize_per_types_url_2501691_42.patch | 4.74 KB | Revathi.B |
Comments
Comment #1
Dom. CreditAttribution: Dom. commentedComment #3
Dom. CreditAttribution: Dom. commentedShould be better this time.
Comment #4
Dom. CreditAttribution: Dom. commentedComment #5
Dom. CreditAttribution: Dom. commentedComment #6
Dom. CreditAttribution: Dom. commentedComment #7
YesCT CreditAttribution: YesCT commentedsince this is a normal task, let's get a beta evaluation on this to see if it is an allowed change.
https://www.drupal.org/contributor-tasks/update-allowed-beta
Comment #8
Dom. CreditAttribution: Dom. commentedComment #9
Dom. CreditAttribution: Dom. commentedComment #10
cbanman CreditAttribution: cbanman at Acro Commerce commentedPatch RTBC:
- reviewed code
- checked URLs for content-types pre-patch
- checked URLs for comment-types pre-patch
- applied patch
- confirmed changes in URLs for content-types post-patch
- confirmed changes in URLs for comment-types post-patch
Everything appears to be working as intended.
Comment #16
Dom. CreditAttribution: Dom. commentedUpdate patch #3 regarding latest commit on HEAD from #2350683: File field "Enable Description field" setting cannot be saved via instance settings in UI.
Comment #17
Manjit.Singhmanually test #16 patch.
URL changes to
There are some screenshots after applied patch. Please have a look into it.
Before
After
Comment #18
larowlanMakes sense to me
Comment #19
xjmThanks for the screenshots and the beta evaluation!
I definitely see the case for this change. However, I think the disruption documented in the beta evaluation is not complete. We also need to look at the impact on existing sites, which may sometimes hardcode paths in links in content fields, e.g.
<a href="/admin/structure/blah"></a>
, and weigh the disruption against the benefit of making the change. Broken links are a reasonably easy thing to fix, many sites run reports for them, and as admin paths they're less likely to be linked all over in content, but it is still a disruption. (I'm also not sure about this, but it could potentially break some custom views stuff maybe, since IIRC views might rely on paths instead of routes in the UI in some places. etc. Worth double-checking, at least.)Since these paths are also a reasonably important and commonly used part of our IA, I think it would also be good to have a usability maintainer signoff, so tagging for that. (We already have a comment maintainer signoff from larowlan.) Also tentatively tagging for product manager goodness (it's not a hugely significant change product-wise, but we can always assign to @webchick for a looksee if we RTBC it again after discussing).
I've updated the remaining tasks section of the summary and the beta evaluation to reflect my remarks here.
Comment #20
Dom. CreditAttribution: Dom. commentedAdded block types in the loop : those also have even weirder URLs plus as named block-content which seems a duplicate notion from block-types (see updated issue description).
Comment #21
Dom. CreditAttribution: Dom. commentedComment #23
andypostIt makes sense to normilize menu-items here as well
Suggest to make a review of all config types and fix menu-links weights as well, so issue title
Comment #24
Dom. CreditAttribution: Dom. commentedI mixed things up between /admin/structure/block/block-content and /admin/structure/block/block-content/types. This patch corrects it.
Regarding @andypost #23, what does it imply, what should I do thus as a following work ?
Comment #25
andypost@Dom. At least to check other entities (aggregator, taxonomy) and their paths, I'm sure that changing a weight of menu items should be separate issue
Comment #28
anavarreComment #29
Manjit.Singhrerolled a patch.
Comment #30
Manjit.SinghComment #35
Bojhan CreditAttribution: Bojhan as a volunteer commentedThis makes sense we now have too much "types" and by consistently prefixing them with the "type" of content this refers to we should make it more understandable where the given entity is related to. Thanks for flagging this.
Comment #36
xjmThanks @Bojhan!
Since this involves changes to the information architecture and would be disruptive for existing sites because it could break links, moving to 8.1.x.
Comment #37
xjmComment #39
geerlingguy CreditAttribution: geerlingguy commentedAs part of this issue, can we also add a link to 'Block types' after 'Block layout'? It's quite unintuitive to go to the
admin/structure
page to manage 'Content types' and 'Comment types', but then I have to go to 'Block layout', then 'Custom block library' to finally find a text link over to the 'Custom block types' admin page :/Comment #40
Revathi.B CreditAttribution: Revathi.B commentedI have to change all the files which are using that path or URL even the test files also I have to change the URL.Because of URL should not be conflict.
Comment #41
geerlingguy CreditAttribution: geerlingguy commentedThis patch has a lot of commented code...
Comment #42
Revathi.B CreditAttribution: Revathi.B commentedComment #43
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions commentedComment #44
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions commentedRemoved the commented code.
Comment #46
Sonal.Sangale CreditAttribution: Sonal.Sangale at Blisstering Solutions commentedComment #47
Manjit.Singhanybody have any idea why it is failing ?
Comment #50
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Valuebound commentedComment #51
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Valuebound commentedI have changed the Content type, comment and blocks url according to Proposed Solution for 8.4.x branch
Please Review.
Thanks!!
Comment #53
rajeshwari10 CreditAttribution: rajeshwari10 as a volunteer and at Valuebound commentedComment #56
Ivan Berezhnov CreditAttribution: Ivan Berezhnov as a volunteer and at Drupal Ukraine Community for Levi9 commentedComment #58
Sonal.Sangale CreditAttribution: Sonal.Sangale at QED42 commented