Problem/Motivation
The intent of this issue is to coordinate efforts in the creation of the 4.0.22 release of the Environment Indicator module.
As of the creation of this issue, the module is stable and supports Drupal 9.3, 10.x, and 11.x. The 4.0.22 release will focus on resolving minor bugs reported or fixed since the 4.0.21 release, improving overall code quality, and ensuring continued compatibility with the latest versions of Drupal.
Release-blocker issues (Bug fixes)
- #3519033: Add back PHP 7.3 and Drupal 9.3 version compatibility
- #3487202: Gin vertical toolbar submenu's overlap
- #3484495: Separate Tinycon into its own library and use favicon option to determine inclusion.
- #3425491: Hostname field isn't a hostname but a base URL
- #3481872: Delete unused color.js file and remove from library definitions.
- #3482961: Remove version key from environment_indicator.libraries.yml
- #3101814: Environment Switcher entity uses "edit-permissions-form" link template from user_role
- #3341110: Toolbar is colored when toolbar integration is off
- #3484735: Move toolbar integration into submodule.
- #3065135: Add support for multilingual domain sites
- #3524269: [Regression] Basic environment indicator dropdown links are inaccessible.
- #3526658: Create new Indicator service and deprecate ToolbarHandler methods getTitle, getCurrentRelease, getVersionIdentifier, hasAccessAll, hasAccessEnvironment, hasAccessActiveEnvironment, getLinks, getCacheTags
Good-to-fix issues (Code Quality and CI)
- #3483068: Fix PHPStan Issues
- #3483055: Fix stylelint issues.
- #3481793: Fix ESLint Errors following Drupal coding standards and best practices
- #3481334: Fix cspell issues
- #3338199: Fix PHPCS Errors following Drupal coding standards and best practices
- #3128882: Documentation guide update
- #3500006: Create basic PHPUnit tests.
- #3487973: Add Gin theme to Tugboat configuration.
Remaining tasks
- Establish a list of release-blockers and 'good-to-fix' issues for the 4.0.22 release.
- Resolve the above issues blocking the release.
- Merge all merge requests for the listed issues. (Merging into the 4.x-dev branch can be done at any time after the release of 4.0.21. No release required.)
- Create 4.0.22 stable release.
Issue fork environment_indicator-3483897
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
trackleft2Comment #3
trackleft2Comment #4
trackleft2Comment #5
trackleft2Comment #6
trackleft2Comment #7
trackleft2Comment #8
trackleft2Comment #9
trackleft2Comment #10
trackleft2Comment #11
trackleft2Comment #12
trackleft2Comment #13
isholgueras commentedI was creating the issue for 4.0.21 until I realized you also created it.
I was wondering to if it makes sense to plan this release (maybe one more release) to be the latest release before 4.1. I wouldn't like to maintain 2 different version unless it's strictly necessary.
I would like to add to this release these issues (some leftovers from 4.0.20 release and some new)
Release-blocker issues (Bug fixes)
Good-to-fix issues (Good to have)
There are more issues I would like to work on and add to the release, but at least this is a good amount of issues to include in 4.0.21. What do you think?
Comment #14
trackleft2Thanks for merging. I think your list for 4.0.22 looks good,
and possibly #3494122: Environmental indicator incorrect version identifierIMHO we should start dropping support for older versions of Drupal core with the first minor release (4.1.0), so we can begin to take advantage of some of the newer OOP patterns and core features.
I don't think supporting multiple release branches is necessary, since there is an upgrade path.
Comment #15
isholgueras commentedComment #16
trackleft2Comment #17
trackleft2Comment #18
trackleft2Comment #19
trackleft2Let's work on merging the code quality (Gitlab CI) merge requests and fixing the inevitable merge conflicts that will occur as a result. I'll volunteer to update any merge requests that need it.
Comment #20
trackleft2Comment #21
trackleft2Comment #22
trackleft2Comment #23
trackleft2Comment #24
trackleft2Comment #25
trackleft2Comment #26
trackleft2Comment #27
trackleft2Comment #28
trackleft2Comment #29
trackleft2Comment #30
trackleft2Comment #31
trackleft2Comment #32
trackleft2Comment #34
trackleft2