Problem/Motivation

The standard cspell test we run for each pull request and merge has some failures.

./css/environment_indicator.css:2:5       - Unknown word (enviroment) -- --enviroment-indicator-border-width
./css/environment_indicator.css:80:22     - Unknown word (enviroment) -- border-left: var(--enviroment-indicator-border-width
./css/environment_indicator.css:84:21     - Unknown word (enviroment) -- border-top: var(--enviroment-indicator-border-width
./css/environment_indicator.css:89:21     - Unknown word (enviroment) -- margin-top: var(--enviroment-indicator-border-width

./environment_indicator.libraries.yml:6:8       - Unknown word (tinycon)    -- js/tinycon.min.js: { minified:
./environment_indicator.module:25:209    - Unknown word (sset)       -- using drush: <code>drush sset environment_indicator
./environment_indicator.module:35:256    - Unknown word (customisations) -- site theme, substantial customisations require modifications
	 Suggestions: [customizations, customization, customization's]
./environment_indicator.module:49:209    - Unknown word (sset)           -- using drush: <code>drush sset environment_indicator
./js/environment_indicator.js:17:81     - Unknown word (enviroment) -- getPropertyValue('--enviroment-indicator-border-width
./js/environment_indicator.js:28:109    - Unknown word (enviroment) -- margin-left': 'calc(var(--enviroment-indicator-border-width
./js/environment_indicator.js:42:40     - Unknown word (Tinycon)    -- environmentIndicatorTinycon = {
./js/environment_indicator.js:44:23     - Unknown word (tinycon)    -- $(once('env-ind-tinycon', 'html', context))
./js/environment_indicator.js:49:11     - Unknown word (Tinycon)    -- Tinycon.setBubble(settings.environmen
./js/environment_indicator.js:50:11     - Unknown word (Tinycon)    -- Tinycon.setOptions({
./js/tinycon.min.js:2:4       - Unknown word (Tinycon)    -- * Tinycon - A small library for
./js/tinycon.min.js:7:3571    - Unknown word (Tinycon)    -- exports = a : window.Tinycon = a }();
./README.md:159:20    - Unknown word (mrfelton)   -- * Tom Kirkpatrick (mrfelton) - https://www.drupal
./README.md:160:3     - Unknown word (isholgueras) -- * isholgueras - https://www.drupal

Proposed resolution

Search and replace: customisations with customizations.
Search and replace: enviroment with environment
Replace sset with state:set per https://www.drush.org/12.x/commands/state_set/

Add four words to the .cspell-project-words.txt

  • Tinycon
  • tinycon
  • mrfelton
  • isholgueras

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork environment_indicator-3481334

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

trackleft2 created an issue. See original summary.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Issue summary: View changes
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Issue summary: View changes

trackleft2 opened merge request !64

sayan_k_dutta’s picture

sayan_k_dutta commented
Assigned: Unassigned » sayan_k_dutta

Working on it

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Active » Needs review
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

@sayan_k_dutta there is already a merge request if you would like to test it.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

@Sayan_K_Dutta, Please remove the changes that you made in order to quiet PHPCS, those should be addressed in #3338199: Fix PHPCS Errors following Drupal coding standards and best practices

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Needs work
sayan_k_dutta’s picture

sayan_k_dutta commented
Assigned: sayan_k_dutta » Unassigned
Status: Needs work » Needs review

Tested the MR, works fine as expected. All the required words have been replaced and the four words haven been added to the .cspell-project-words.txt file. Reverted the phpcs changes made before.

sayan_k_dutta’s picture

sayan_k_dutta commented
Status: Needs review » Reviewed & tested by the community
sayan_k_dutta’s picture

sayan_k_dutta commented

@maintainers, please merge and close this issue if it has been fixed.

trackleft2 changed the visibility of the branch 4.x to hidden.

  • trackleft2 committed aa01da40 on 4.x 
    Issue #3481334 by trackleft2, sayan_k_dutta: Fix cspell errors and fail...
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

Granting credit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.