Problem/Motivation

With gitlab ci this module has access to automated testing with PHPStan, unfortunately the tests are failing at the moment.

Steps to reproduce

https://git.drupalcode.org/project/environment_indicator/-/jobs/3032502

Proposed resolution

Add a phpstan.neon file to let PHPStan know about our custom entity.

Remaining tasks

  • Add a phpstan.neon file to let PHPStan know about our custom entity.
  • Set gitlab to not allow merging if the phpstan check fails.phpstan:
    allow_failure: false

User interface changes

API changes

Data model changes

Issue fork environment_indicator-3483068

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

trackleft2 created an issue. See original summary.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Issue summary: View changes

trackleft2 opened merge request !70

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review

phpstan tests now pass. Only one simple change needed.

trackleft2 changed the visibility of the branch 4.x to hidden.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Issue summary: View changes

  • trackleft2 committed 5c6abc45 on 4.x 
    Issue #3483068 by trackleft2, liam morland: Fix PHPStan Issues, and...
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.