Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
The bug is that the favicon javascript is run regardles of whether the favicon option is checked.
We have a checkbox on the environment indicator settings form that give the illusion that you have a choice as to whether the tinycon javascript loads.
Steps to reproduce
Do not choose the favicon option.
Notice Tinycon library continues to load.
Proposed resolution
Separate Tinycon into its own library and use favicon option to determine inclusion.
Remaining tasks
Create a merge request to separate Tinycon library.
User interface changes
N/A
API changes
Selecting favicon option should include the library.
Data model changes
N/A
Issue fork environment_indicator-3484495
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
trackleft2This merge request separates out the Tinycon and favicon functionality into separate libraries from the environment_indicator/drupal.environment_indicator library.
Using the favicon option in
environment_indicator.settingsand the Drupal libraries and javascript APIs we can serve the Tinycon and favicon libraries.Comment #4
trackleft2Comment #5
trackleft2Comment #6
trackleft2Comment #9
trackleft2