Problem/Motivation

In the annotation of the Environment Switcher (environment_indicator) entity type is a stray link template from the user module. This is likely a copy-paste error from way back, but can lead to strange situations when code relies on these link templates.

Proposed resolution

Remove the incorrect edit-permissions-form link template.

Remaining tasks

Review & commit.

CommentFileSizeAuthor
#2 environment_indicator-permissions_link_template-3101814-2.patch670 bytesckaotik

Issue fork environment_indicator-3101814

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ckaotik created an issue. See original summary.

ckaotik’s picture

ckaotik
Primary language German
Location Berlin
commented
Assigned: ckaotik » Unassigned
Status: Active » Needs review
StatusFileSize
new environment_indicator-permissions_link_template-3101814-2.patch670 bytes

Attached is a trivial patch to fix the issue.

tessa bakker’s picture

tessa bakker
she/they
Primary language Dutch
commented
Version: 8.x-3.x-dev » 4.x-dev
Status: Needs review » Needs work
Issue tags: +Needs reroll

Re-roll needed for 4.x

trackleft2 made their first commit to this issue’s fork.

trackleft2 opened merge request !66

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs work » Needs review

Added a merge request that copies the patch.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented

Patch and MR LGTM. +1 for RTBC.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

isholgueras made their first commit to this issue’s fork.

isholgueras’s picture

isholgueras commented
Status: Reviewed & tested by the community » Fixed

Tested and works fine. Thanks! Ready for the 4.0.22 version.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.