Problem/Motivation

Stylelint issues are occurring in the Stylelint job following the GitLab integration for the environment_indicator module. These need to be addressed to comply with Drupal CSS coding standards.

See: https://git.drupalcode.org/project/environment_indicator/-/pipelines

Steps to reproduce

  1. Clone the environment_indicator module repository.
  2. Set up the GitLab CI/CD environment.
  3. Run the Stylelint job.
  4. Check for linting errors in the job logs.

Proposed resolution

  • Update the CSS files to comply with Drupal CSS coding standards.
  • Configure gitlab to not allow merging if stylelint job doesn't pass.
    stylelint:
  allow_failure: false

Remaining tasks

  • Fix specific Stylelint errors.
  • Test the Stylelint job after changes.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork environment_indicator-3483055

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

trackleft2 created an issue. See original summary.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Issue summary: View changes
arunsahijpal’s picture

arunsahijpal commented
Assigned: Unassigned » arunsahijpal

Working on it!

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

OK, but there will probably be merge conflicts with #3481334: Fix cspell issues that you'll need to account for.

arunsahijpal opened merge request !74

arunsahijpal’s picture

arunsahijpal commented
Assigned: arunsahijpal » Unassigned
Status: Active » Needs review

Hi @trackleft2,
I've fixed all the Stylelint errors and there is not any merge conflict in the MR, kindly review it.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Needs work

@arunsahijpal what about the gitlab part from the issue summary?

Configure gitlab to not allow merging if stylelint job doesn't pass.

arunsahijpal’s picture

arunsahijpal commented
Status: Needs work » Needs review

Hi @trackleft2,
I've configured gitlab-ci.yml file to not allow merging if stylelint job doesn't pass.
Pls give it a look.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

Thanks, nice work!

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

Needs work, there is an upstream merge conflict now.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs work » Needs review

Updated this Merge Request to incorporate upstream changes from #3487202: Gin vertical toolbar submenu's overlap
Note:
- This merge request changes fallback variable names to comply with style lint rules (Possibly a breaking change for people using the old variable)

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

Once this is reviewed and merged we'll finally have all useful (passing) CI tests..

trackleft2 changed the visibility of the branch 4.x to hidden.

trackleft2 opened merge request !89

trackleft2 changed the visibility of the branch 3483055-fix-stylelint-issues-tugboat to hidden.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Related issues: +#3524015: Remove Gin Admin Theme legacy fallbacks and modernizr fallbacks
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

I've updated this to remove some SCSS that was added in here by mistake.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

I've reviewed this several times and I think it is ready for merging.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.