Problem/Motivation

I installed the module, setup settings in settings.local.php, disable toolbar integration.

Expectation:
See only colored bar

Reality:
Toolbar is also colored

screenshot

Steps to reproduce

Install module as usual

Add settings to settings.local.php

$config['environment_indicator.indicator']['name'] = 'Local';
$config['environment_indicator.indicator']['fg_color'] = '#ffffff';
$config['environment_indicator.indicator']['bg_color'] = '#1C71D8';

Disable toolbar integration

screenshot

Clear drupal cache

CommentFileSizeAuthor
Screenshot_20230212_150326.png30.06 KBivnish
Screenshot_20230212_150335.png51.72 KBivnish

Issue fork environment_indicator-3341110

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ivnish created an issue. See original summary.

rsnyd’s picture

rsnyd
Primary language English
Location Northeast Pennsylvania
commented

Same issue. Similar problem here?

https://www.drupal.org/project/environment_indicator/issues/3077679

rsnyd’s picture

rsnyd
Primary language English
Location Northeast Pennsylvania
commented

@e0ipso, @mrfelton, @isholgueras, Changes made to origin/3341110-toolbar-is-colored branch that fix the disabling of the toolbar integration.

ivnish opened merge request !46

ivnish’s picture

ivnish
he/him
commented

I created MR from @rsnyd branch

ivnish’s picture

ivnish
he/him
commented
Version: 4.0.14 » 4.x-dev
Category: Support request » Bug report
Status: Active » Needs work

I manually tested this MR. With this code toolbar is never colored.

ivnish closed merge request !46

ivnish opened merge request !47

ivnish changed the visibility of the branch 3341110-toolbar-is-colored to hidden.

ivnish’s picture

ivnish
he/him
commented
Status: Needs work » Needs review
krakenbite’s picture

krakenbite commented
Status: Needs review » Reviewed & tested by the community

Looks good for me. Please commit

trackleft2 made their first commit to this issue’s fork.

  • trackleft2 committed 91751365 on 4.x authored by ivnish 
    Issue #3341110 by ivnish, trackleft2, rsnyd, krakenbite: Toolbar is...
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

Granting credit

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.