Acceptance Criteria
We have improved the translations for recipes, following the style guide at #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.. These need to be included to allow showcasing of Drupal's multiple language capabilities.
Technical Details
The following Issues have edits in a google doc and issue summaries/comments that need to be rolled into the CSV file. (Already listed in parent [META] Issue.)
#3028788: Umami Recipe Spanish Translation: Deep mediterranean quiche
#3028790: Umami Recipe Spanish Translation: Vegan chocolate brownies
#3028791: Umami Recipe Spanish Translation: Super easy vegetarian pasta bake
#3028792: Umami Recipe Spanish Translation: Watercress soup
#3028793: Umami Recipe Spanish Translation: Victoria sponge cake
#3028797: Umami Recipe Spanish Translation: Gluten free pizza
#3028798: Umami Recipe Spanish Translation: Thai green curry
#3028800: Umami Recipe Spanish Translation: Crema catalana
#3028801: Umami Recipe Spanish Translation: Fiery chili sauce
Update the CSV file found in core: /core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/recipe.csv
Add / update all recipe instructions under this directory:
/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/recipe_instructions/
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | interdiff_3-20.txt | 3.61 KB | shaal |
| #20 | ootb-ml-spanish-recipes-3042699-20.patch | 13.91 KB | shaal |
| #3 | ootb-ml-spanish-recipes-3042699-3.patch | 13.89 KB | shaal |
Comments
Comment #2
shaalOnce all these content issues get marked as FIXED, we can roll them in.
Comment #3
shaalAdded last few recipes:
#3028788: Umami Recipe Spanish Translation: Deep mediterranean quiche
#3028801: Umami Recipe Spanish Translation: Fiery chili sauce
#3028793: Umami Recipe Spanish Translation: Victoria sponge cake
Updated:
#3028790: Umami Recipe Spanish Translation: Vegan chocolate brownies
There were few missing ingredients in #3028788: Umami Recipe Spanish Translation: Deep mediterranean quiche, I rather have the recipe in Spanish in core, and later make a patch that fix the minor changes needed.
Comment #4
kjay commentedGreat work!
I've tested this patch and it applies without problem. Installation of Umami from the profile selection screen worked as expected and the logs post installation looked normal.
I switched between the content in English and Spanish for each of the new recipes and the content looked to tally well with the exception of Mediterranean quiche which as noted in #3 still has some of its ingredients in English and is proposed to be fixed in a follow up when those translations arrive.
I believe this is ready for RTBC given it is better to have all the content translations present and we can fix missing strings as a priority, which is already going on with other parts of the interface anyway.
Comment #5
gábor hojtsyComment #6
gábor hojtsyPlease assign credits to contributors to these translations before commit.
Comment #19
kjay commentedGreat work everyone! Assigning credit to those who worked on the related translation issues.
Comment #20
shaalAdded the missing ingredients that were mentioned in #3
Comment #21
kjay commentedReviewed by installing and checking the article now has the translated ingredients. Recipe looks as it should and ready to go! Putting back to RTBC.
Comment #24
gábor hojtsyThanks all!