Acceptance Criteria

We have improved the translations for recipes, following the style guide at #3011647: [policy, no patch] Standardize writing style for Umami in Spanish.. These need to be included to allow showcasing of Drupal's multiple language capabilities.

Technical Details

The following Issues have edits in a google doc and issue summaries/comments that need to be rolled into the CSV file. (Already listed in parent [META] Issue.)
#3028788: Umami Recipe Spanish Translation: Deep mediterranean quiche
#3028790: Umami Recipe Spanish Translation: Vegan chocolate brownies
#3028791: Umami Recipe Spanish Translation: Super easy vegetarian pasta bake
#3028792: Umami Recipe Spanish Translation: Watercress soup
#3028793: Umami Recipe Spanish Translation: Victoria sponge cake
#3028797: Umami Recipe Spanish Translation: Gluten free pizza
#3028798: Umami Recipe Spanish Translation: Thai green curry
#3028800: Umami Recipe Spanish Translation: Crema catalana
#3028801: Umami Recipe Spanish Translation: Fiery chili sauce

Update the CSV file found in core: /core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/node/recipe.csv

Add / update all recipe instructions under this directory:
/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/recipe_instructions/

Comments

kwfinken created an issue. See original summary.

shaal’s picture

Version: 8.8.x-dev » 8.7.x-dev
Issue summary: View changes

Once all these content issues get marked as FIXED, we can roll them in.

shaal’s picture

kjay’s picture

Status: Needs review » Reviewed & tested by the community

Great work!

I've tested this patch and it applies without problem. Installation of Umami from the profile selection screen worked as expected and the logs post installation looked normal.

I switched between the content in English and Spanish for each of the new recipes and the content looked to tally well with the exception of Mediterranean quiche which as noted in #3 still has some of its ingredients in English and is proposed to be fixed in a follow up when those translations arrive.

I believe this is ready for RTBC given it is better to have all the content translations present and we can fix missing strings as a priority, which is already going on with other parts of the interface anyway.

gábor hojtsy’s picture

Title: Roll Recipe google docs into CSV » Add the missing three Spanish Umami recipes and fix translation of chocolate brownies
Version: 8.7.x-dev » 8.8.x-dev
gábor hojtsy’s picture

Status: Reviewed & tested by the community » Needs work

Please assign credits to contributors to these translations before commit.

kjay credited Adita.

kjay credited Adrian_S_M.

kjay credited Eli-T.

kjay credited bsnodgrass.

kjay credited cosmicdreams.

kjay credited ddavidd.

kjay credited estoyausente.

kjay credited gaddamsr.

kjay credited heddn.

kjay credited mike.roman.

kjay credited mradcliffe.

kjay credited saesa.

kjay’s picture

Status: Needs work » Reviewed & tested by the community

Great work everyone! Assigning credit to those who worked on the related translation issues.

shaal’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new13.91 KB
new3.61 KB

Added the missing ingredients that were mentioned in #3

kjay’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed by installing and checking the article now has the translated ingredients. Recipe looks as it should and ready to go! Putting back to RTBC.

  • Gábor Hojtsy committed 1dd4248 on 8.8.x
    Issue #3042699 by shaal, kjay, kwfinken, Eli-T, Adita, Adrian_S_M,...

  • Gábor Hojtsy committed b8498cd on 8.7.x
    Issue #3042699 by shaal, kjay, kwfinken, Eli-T, Adita, Adrian_S_M,...
gábor hojtsy’s picture

Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.