Problem/Motivation

In order for Umami to showcase multilingual capabilities in English and Spanish, we need to have CSV files with content in Spanish.

This is done in parallel to #3029839: Multilingual functionality - enable English and Spanish as part of Umami installation
and will become visible when #3037111: Import multilingual content into Umami is completed.

Proposed resolution

Generate CSV files for the recipe content type content that are marked as fixed in #3028769: [META] Showcase Drupal's Multilingual Capabilities by implementing Umami in a 2nd language (Spanish)

CommentFileSizeAuthor
#19 interdiff_16-19.txt598 bytesshaal
#19 ootb-ml-spanish-recipes-csv-3038309-19.patch12.54 KBshaal
#16 interdiff_15-16.txt1.07 KBshaal
#16 ootb-ml-spanish-recipes-csv-3038309-16.patch12.57 KBshaal
#15 interdiff_4-15.txt6.87 KBshaal
#15 ootb-ml-spanish-recipes-csv-3038309-15.patch12.54 KBshaal
#4 ootb-ml-spanish-recipes-csv-3038309-4.patch7.2 KBshaal

Comments

shaal created an issue. See original summary.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented

The initial patch will contain the following recipe Spanish translations:
#3028792: Umami Recipe Spanish Translation: Watercress soup
#3028797: Umami Recipe Spanish Translation: Gluten free pizza
#3028798: Umami Recipe Spanish Translation: Thai green curry
#3028800: Umami Recipe Spanish Translation: Crema catalana

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Status: Active » Needs review
StatusFileSize
new ootb-ml-spanish-recipes-csv-3038309-4.patch7.2 KB

The patch includes CSV files of recipes that have a translation

smaz’s picture

smaz
Primary language English
Location England, UK
commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly, Umami still installs ok, CSV file in the correct format. This looks fine to me!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

#3028791: Umami Recipe Spanish Translation: Super easy vegetarian pasta bake is fixed as well. Since we don't have the crediting situation figured out here anyway, we have an opportunity to include that too.

kjay credited Eli-T.

kjay credited estoyausente.

kjay credited isholgueras.

kjay credited rteijeiro.

kjay credited saesa.

kjay’s picture

kjay commented

kjay credited rjfg.

kjay’s picture

kjay commented

Adding credit for translation work done on the Vegan Chocolate recipe.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Status: Needs work » Needs review
StatusFileSize
new ootb-ml-spanish-recipes-csv-3038309-15.patch12.54 KB
new interdiff_4-15.txt6.87 KB

Added 2 more recipes (that appear in the hero blocks - homepage and recipes page)
#3028790: Umami Recipe Spanish Translation: Vegan chocolate brownies
#3028791: Umami Recipe Spanish Translation: Super easy vegetarian pasta bake

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
StatusFileSize
new ootb-ml-spanish-recipes-csv-3038309-16.patch12.57 KB
new interdiff_15-16.txt1.07 KB

Adding a missing translated sentence in Thai green curry recipe (#3028798: Umami Recipe Spanish Translation: Thai green curry)

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Reviewed & tested by the community

Patch applies well and recipe and instructions files are created properly. If there is anything else I must check, just let me know.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: CSV files for Umami's recipes in Spanish » Spanish translations of Umami demo recipes
Status: Reviewed & tested by the community » Needs work

I looked at the markup, since I don't know Spanish :) Markup looks fine. Spanish was reviewed and provided by folks @kjay already credited. This needs fixing though:

+++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/recipe_instructions/veggie-pasta-bake-umami.html
@@ -0,0 +1,8 @@
+</ol>
\ No newline at end of file

Certainly needs a newline here :)

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Status: Needs work » Needs review
StatusFileSize
new ootb-ml-spanish-recipes-csv-3038309-19.patch12.54 KB
new interdiff_16-19.txt598 bytes

Added the missing newline at the end of veggie-pasta-bake-umami.html file.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Status: Needs review » Reviewed & tested by the community

A minor fix, self RTBC'ing :)

  • Gábor Hojtsy committed 9006714 on 8.8.x 
    Issue #3038309 by shaal, rteijeiro, kjay, Eli-T, smaz, estoyausente,...

  • Gábor Hojtsy committed 6a3e6fa on 8.7.x 
    Issue #3038309 by shaal, rteijeiro, kjay, Eli-T, smaz, estoyausente,...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Superb, thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.