[D7] Add Menu child item

Updating to : Drupal.org Project applications

Please update accordingly https://www.drupal.org/node/1011698 and https://www.drupal.org/project/projectapplications

Update clone link as follow

git clone --branch 7.x-1.x https://git.drupal.org/sandbox/sudishth/2730509.git menu_child_item
cd menu_child_item

Please fix online review issue : http://pareview.sh/pareview/httpgitdrupalorgsandboxsudishth2730509git

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2730511

Project 2: https://www.drupal.org/node/2721533

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
I don't know if its duplication but in form listing all menu links, you can drag to re-order menu links and make them child. This module adds link to achieve the same goal.

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
No: Does not follow the guidelines for project length and complexity.
Very small module. There is only 61 lines of PHP code.

Secure code
Yes: Meets the security requirements.

Coding style & Drupal API usage
In menu_child_item.module file:

severity: normalreview: style_uppercase_constantsLine 21: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE [style_uppercase_constants]
    'page arguments' => array('menu_edit_item', 'add', null, 4),
severity: normalreview: style_paren_spacingLine 55: use a space between the closing parenthesis and the open bracket [style_paren_spacing]
  if ($form_id == 'menu_edit_item' && arg(5) =='add-child'){

This project application is missing the following items:

1. A detailed description of the project.
2. A link to the project page

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2721533

Project 2: https://www.drupal.org/node/2730511

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Yes, but we will only approve you once, than you can promote all your projects.

@sudishth

The Module works fine.Here is my review for your module

Automated Review

No problem found

Manual Review

Individual user account

Yes: Follows guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows licensing requirements

README.txt/README.md

Yes: Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

Anything that user sees must pass through t

Line 42 in menu_child_item.module() #title' => 'add child',

should be '#title' => t('add child'),

Remove unnessary comment at line 56

//print_r($form_state);

There is typo mistake for comment block for Menu_child_form_alter

Replace "for set defoult parent."

with "To set default parent."

@namit.garg: looks like you forgot to change the status? Looks like the points you found are good tips for improvements but not application blockers - anything else or should this be RTBC?

@klausi

The module works fine . Actually i have been working on drupal from 6 months only . so there could be some issues that i could not catch that's why i did not change the status.
Changing the status now

You should remove "Parent link" select box under Add Menu child item form.

Simple module, works fine.

Minor fiixes: http://pareview.sh/pareview/httpsgitdrupalorgsandboxsudishth2730509git

But nothing against to promote this as a full project, so:

Thanks for your contribution, sudishth!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.