[D7] Translate.com Website Translator

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgsandboxtranslatecom2723595git

I'm a robot and this is an automated message from Project Applications Scraper.

Please note that before adding tags, you should read the issue tag guidelines. Do NOT use tags for adding random words. I've now removed the random words you added.

Please note that before adding tags, you should read the issue tag guidelines. Do NOT use tags for adding random keywords. I've now removed the random tag you added.

Here is a list of all project applications currently waiting for review. Just now, your application is on very bottom on the last page, which means that its spot in the waiting list is #187.

Every time you add a tag to your application, you're moved down to the bottom of this list. In other words, doing this random tagging may result in you having to wait longer for a review by a human reviewer.

One way to bypass this waiting list is to earn a review bonus. If you want a review anytime soon, you should try that.

I've fixed the instructions for cloning the sandbox in the issue summary for you.

Three days ago you wrote:

Ready for review, all of the style issues the auto check found are corrected.

No, they're not. Please click on this link:
http://pareview.sh/pareview/httpsgitdrupalorgsandboxtranslatecom2723595git

Fix the style issues, add the README.md, and make sure you check this one out:

FILE: /var/www/drupal-7-pareview/pareview_temp/website_translator.module
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
39 | WARNING | The administration menu callback should probably use
| | "administer site configuration" - which implies the user
| | can change something - rather than "access administration
| | pages" which is about viewing but not changing
| | configurations.
---------------------------------------------------------------------------

If it is not a false positive, you should fix it. If it is a false positive, point that out so that reviewers will not keep complaining about it.

No, that is not a false positive. Any user that has the permission "access administration pages" is able to make changes on admin/config/regional/website_translator, but only admins with a permission to change something should be able to. For example with "administer site configuration".

Automated Review
No problem found
Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows licensing requirements
README.txt/README.md
Yes: Follows guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
used with default value variable_get('variable_name',''), https://api.drupal.org/api/drupal/includes!bootstrap.inc/function/variab...

Its good to have directory name(translate_com_website_translator) and module name(website_translator) same.

Automated Review

Please fix reported issue on https://pareview.sh/node/209

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[No: Does not follow] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. (*) Please remove all variables used in module under hook_uninstall

// True by default.
  variable_set('website_translator_remember_language', "true");
  variable_set('website_translator_guess_language', "true");
  variable_set('website_translator_localize_images', "true");

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.