This project integrates Signature Pad by adding a field for both content (nodes) as well as the Field API. It is similar to another project that implements Signature Pad; but this project implements the field into FAPI. It is also considered RC, vs. dev.
A link to the project page is:
https://www.drupal.org/sandbox/greatmatter/2716303
The git clone command is:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/greatmatter/2716303.git e_sign
I'm afraid I haven't done other application reviews--I didn't even realize it was part of the process until now! I will, however, do application reviews going forward.
Thank you, all, for your consideration!
Comments
Comment #2
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
shkiper commentedAutomated Review
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
Manual Review
drupal_set_errorComment #4
greatmatter commentedI've updated the README.txt and added hook_help. I also fixed the undefined function error.
I'm still wrapping my head around writing SimpleTests for this, so for now, I think I'm going to skip it.
Regarding the duplication: how do I get around that? The module appears abandoned, and we need a non-dev release.
Comment #5
greatmatter commentedPerformed some minor bug fixes.
Comment #6
sudishth commentedAutomated Review
No problem found
Manual Review
Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows licensing requirements
README.txt/README.md
Yes: Follows guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
remove unused functions
$(window).resize(function(){
// resizeCanvas(canvas_' . $delta . ');
});
Comment #7
klausi@sudishth: looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?
Comment #8
sudishth commentedComment #9
misc commentedThanks for your contribution, greatmatter!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.
Comment #11
greatmatter commentedHey there--I don't have the "Promote" tab on the module; do I have the permission?
Comment #12
misc commentedSorry, must have missed to add the right permissions for you. Should be fixed now.