This project integrates Signature Pad by adding a field for both content (nodes) as well as the Field API. It is similar to another project that implements Signature Pad; but this project implements the field into FAPI. It is also considered RC, vs. dev.

A link to the project page is:
https://www.drupal.org/sandbox/greatmatter/2716303

The git clone command is:
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/greatmatter/2716303.git e_sign

I'm afraid I haven't done other application reviews--I didn't even realize it was part of the process until now! I will, however, do application reviews going forward.

Thank you, all, for your consideration!

Comments

greatmatter created an issue. See original summary.

PA robot’s picture

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

shkiper’s picture

Status: Needs review » Needs work

Automated Review

No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

Manual Review

Individual user account
[Yes: Follows] the guidelines for individual user accounts.
No duplication
[No: Causes] module duplication and/or fragmentation. Module SignatureField
Master Branch
[Yes: Follows] the guidelines for master branch.
Licensing
[Yes: Follows] the licensing requirements.
3rd party assets/code
[Yes: Follows] the guidelines for 3rd party assets/code.
README.txt/README.md
[No: Does not follow] the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
[Yes: Follows] the guidelines for project length and complexity.
Secure code
[Yes: Meets the security requirements.]
Coding style & Drupal API usage
  1. Call to undefined function drupal_set_error
greatmatter’s picture

Status: Needs work » Needs review

I've updated the README.txt and added hook_help. I also fixed the undefined function error.

I'm still wrapping my head around writing SimpleTests for this, so for now, I think I'm going to skip it.

Regarding the duplication: how do I get around that? The module appears abandoned, and we need a non-dev release.

greatmatter’s picture

Performed some minor bug fixes.

sudishth’s picture

Automated Review
No problem found
Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows licensing requirements
README.txt/README.md
Yes: Follows guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
remove unused functions
$(window).resize(function(){
// resizeCanvas(canvas_' . $delta . ');
});

klausi’s picture

@sudishth: looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

sudishth’s picture

Status: Needs review » Reviewed & tested by the community
misc’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, greatmatter!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

greatmatter’s picture

Hey there--I don't have the "Promote" tab on the module; do I have the permission?

misc’s picture

Sorry, must have missed to add the right permissions for you. Should be fixed now.