[D7] Informz API Intergation Module

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I had a quick look at this and it needs some work. Please do not consider this to be a comprehensive review.

* Many functions are undocumented
* There is blocks of debugging code commented out
* Is "_integration" needed in the module name? "informz" or "informz_api" is a shorter namespace.
* Function names aren't properly namespaced
* Indentation is all over the place

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxchaitanya172703949git

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello Chaitanya,

Your module looks good, but there are some minor errors reported by automated review tool. Did you check them?

See http://pareview.sh/pareview/httpgitdrupalorgsandboxchaitanya172703949git

Regards,

Please don't assign the review task to yourself. Please see this page about assigning ownership to issues.

Hi chaitanya17,

I have checked and Automated review is passed now.

Thank you,

I had a quick scan of the current version of the code.

The description for the "admin/config/media/informz" menu item isn't very useful.

The phrase "no updation" is used in multiple places.

The module calls domain_get_domain() but doesn't specify domain as a dependency.

The hook_theme() implementation should be using $path instead of the (multiple) calls to drupal_get_path().

The InterestNames are hardcoded in the template file.

change the Git clone URL for users.

Thanks

@dilipsingh02, thanks for fixing the git clone URL!

This application has some random keywords added as tags. I've removed them.

Before adding tags read the issue tag guidelines. Do NOT use tags for adding random keywords.

Automated Review
No problem found
Manual Review

Individual user account
Yes: Follows guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows licensing requirements
README.txt/README.md
Yes: Follows guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
remove it on 108 line
$form['submit'] = array(
'#type' => 'submit',
'#value' => 'Save Configuration',
);
https://api.drupal.org/api/drupal/modules!system!system.module/function/...

@sudishth: looks like you forgot to change the status. Is this now RTBC after your review or are there application blockers left and this should be "needs work"?

Thanks for your contribution, chaitanya17!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.