[D7] cck author

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi surendra77c,

Please check http://pareview.sh/pareview/httpgitdrupalorgsandboxsurendra77c2703111git and try to fix errors.

Manual review:
Lines 44 and 53 - you declared $settings variable but never used it.
Lines 114-115 - you can combine those nested ifs in one if statement.

Hi @surendra77c, could you please update the issue with the URL of your sandbox module, as this will make it easier to review.

Having had a look at the Pareview report there is still a lot of code standard errors which will need to be fixed.

I have managed to find your sandbox module, and having had a look through the code, there is a print_r in the hook_node_presave function.

function cck_author_node_presave($node) {
print_r($node);
}

Please remove this as this function doesn't look like it is needed and there shouldn't be a print_r in any production code.

Updated the status

Hi @surendra77c,

Although you have removed the print_r, the coding standards raised in the Pareview report are still present.

You should look at fixing these first so that this report passes before continuing.

Thanks
Mike

Hi surendra77c,

I have created a patch for your module based on pareview.sh report. Please review the patch and apply to your code. Good luck :)

Thanks
Immanuel Paul

To get people to review your application, you need to set its state to "Needs review", not "Active". Please see project applicaton workflow.

If you're impatient, to give your application a higher priority, please join the review bonus system. If you participate in the system by doing manual reviews, you can put yourself on the high priority list. Applications with PAReview: bonus tag are more likely to receive attention from reviewers and git administrators.

Added Project link and Git URL for this poject.

Your code isn't clean enough yet for me to bother with doing a code review. While you're waiting for one, you can work on the following:

Fix the coding style errors pointed out by http://pareview.sh/pareview/httpgitdrupalorgsandboxsurendra77c2703111git (style errors don't block promotion, but it is more difficult and more work to manually review code with style errors, so I usually don't do a manually review until the code is clean).

Remove the patch that is included in your your repo, it doesn't belong there.

Your project page is empty. What is the use case for this module? As far as I am able to tell, it creates a text field to hold an author name. That field that can be added to the content type under "manage fields". Adding a text field to a content type is already in core. What utility does your module provide that is not already in the core fields module? Please take a moment to make your project page follow the Project page template and it may be a good idea to also read tips for a great project page.

Set the correct values for maintenance status and development status.

Make your README.txt follow the guidelines for in-project documentation and the README.txt Template.

PS: Please also note that there are more applications that yours that Needs review. Some have been waiting longer than yours.

Hi @surendra77c,

I have reviewed your module, nice to see author field to content type created.

You have written hook_schema($field) { //logic } in cck_author.module file.
Proper way will be using .install file. please move related code to install file.

Thanks.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage

• Why display the field label if nothing can be altered
• hook_field_schema should reside in a .install file

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi surendra77c,

I reviewed your module, but it's not clear what you want to implement using this module in cck fields and nothing to be add from the patch that is added in the clone folder.

And you can see nothing happened using this module http://www.screencast.com/t/HKXRD1uYVb6
I think that you want to implement, this can be achieve by using core cck_field by added a text field in to any ctype

Regards
Satyam

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.