[D8] About this node

Hi NarendraR,

I was unable to clone the module. Please check once.

Thanks,
Sarah.

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I have cloned the module. When i install the module. am getting this error.

Fatal error: Call to a member function __toString() on a non-object in /var/www/html/drupal8/modules/custom/_d8__about_this_node/about_this_node.module on line 130

Thanks,
Sarah.

Hello! Your module looks fine, in general.

In your .info you should add dependency to User and Node, to be clear.

Also, move your about_this_node_get_info() function within your block plugin directly, as it is only your block that would be calling the function. then, you can also reduce the name of the function as it would be contained within a class.

IE:

class AboutThisNodeBlock extends BlockBase {
  /**
   * {@inheritdoc}
   */
  public function build() {
    $output = array();
    $node = \Drupal::routeMatch()->getParameter('node');
    if ($node) {
      if ($node->id()) {
        $node_info = this::buildRelatedNodeInfo($node);
        $output = array(
          '#theme' => 'about_this_node',
          '#node_info' => $node_info,
          '#cache' => [
            'max-age' => 0,
          ],
        );
      }
    }
    return $output;
  }

  function buildRelatedNodeInfo($node) {
     // your current form about_this_node_get_info()
  }

}

I might also recommend changing your basic twig file to use the 'Down level' html tag. It's my favourite tag (: as it bring semantic happiness.

You would probably want to add a basic *.libraries.yml to introduce some CSS to your block, as sadly, Down level doesn't come formatted very as we would like, but that's just some CSS.

Individual user account
Yes

Duplication
No

Master Branch
Yes. Branch 8.x-1.x

Licensing
Yes. Follow

3rd party assets/code
Yes follow. Do not contains any 3dr party.

README.txt/README.md
Yes

Code long/complex enough for review
Yes. Well documented. Extending views sort, fields and argument.

Secure code
None security issue found. Looks good.

Coding style & Drupal API usage
After a manuel Review, everything seems to be ok. Perhaps, just some recommandations :
-In the about-this-node.html.twig file.Please add below text of file description in twig coding standards.

 /**
 * @file
 * Template file for example module.
 */
#}

Module works fine, without errors.

@sourabhutani: I think you forgot the change the status. Is this now RTBC or are there any blockers left?

Hm, the twig coding standards thing alone is surely not application blocker, anything else that you found or should this be RTBC instead?

@NarendraR
Problem:
Deprecated

location:
/_d8__about_this_node/src/Plugin/Block/AboutThisNodeBlock.php

problem found on below location:
Function user_load is deprecated (at line 75)
Function user_load is deprecated (at line 105)
Method getUsername is deprecated (at line 76)
Method getUsername is deprecated (at line 106)
Method l is deprecated (at line 78)
Method l is deprecated (at line 108)

Automated Review

No automated tests were found, but that is no reason to block the application.

Manual Review

Individual user account

[Yes: Follows] the guidelines for individual user accounts.

No duplication

[Yes: Does not cause] module duplication and/or fragmentation.

Master Branch

[Yes: Follows] the guidelines for master branch.

Licensing

[Yes: Follows] the licensing requirements.

3rd party assets/code

[Yes: Follows] the guidelines for 3rd party assets/code.

README.txt/README.md

[Yes: Follows] the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

[Yes: Follows] the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements.]

Coding style & Drupal API usage

Nothing to add here.

Everything looks good to me.

This review uses the Project Application Review Template.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2714941

Project 2: https://www.drupal.org/node/2702465

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

I think this works properly,but you can try to tests this with PhpUnit test.
PHPUnit is a testing framework was added to Drupal 8 in June of 2013. Simpletest is still supported but should only be used for web tests and KernelTests that require a complete or partial Drupal environment.

Try this.

Review of the 8.x-1.x branch (commit 1c6ccbd):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
• DrupalPractice has found some issues with your code, but could be false positives. See attachment.
• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:
about_this_node_theme(): what is node_info? Shouldn't you list all the variables that will be used in the template?
::build(): why is the cache max age 0? Please add a comment. I think the block is just dependent on the node, so whenever the node changes the cache of the block should expire. See https://www.drupal.org/developing/api/8/render/arrays/cacheability

Otherwise looks good to me. Although the module is a bit short I think we can approve you since your other project also looks mostly good. This was RTBC already, so I can go ahead right now.

Thanks for your contribution, Narendra!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

forgot attachment.