[D7] Himalaya theme

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxsumitkumar2467223git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

PA Review Error:

FILE: /var/www/drupal-7-pareview/pareview_temp/js/custom.js
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
1 | ERROR | Missing file doc comment
----------------------------------------------------------------------

Also, can you please copy the git clone command for manual review.

Just another quick one. Please consider using Drupal behaviours in custom.js

Hi Sumit,
Thanks for the contribution.
I checked your theme and found some initial issues.

1. When search is enabled for site, main menu disappears (hidden under search box).
2. When main menu button is clicked, it expands. But it does not hide when I click at some random place. (Close only when menu button is clicked again).
3. Cursor should be pointer, when hovered on buttons.
4. Logo and User login title overlap.

Attached are some screenshots.

Changed status to Needs work for earlier posted comment.

Thanks sumit for the contribution. here is my review

1. Un-necessary space after Header in info file.

2. Configuration
   -------------
   
   Find the configuration of theme here: <strong>admin/appearance/settings/himalaya</strong>
   
   

   path that you have mention in README.txt is not working. Please check error.png

3. Info file name is not matched with theme name. Please correct this.
4. Seems like some UI issue in menu.
5. Missing file doc in custom.js file
6. It would be good if you can add some vendor prefixes for browser support
   responsive.css, line no. 31 box-sizing: content-box;
   style.css, line no. 14

   * {
     box-sizing: border-box;
   }

Seems like you forget to add vendor prefixes in style.css file.

* {
  box-sizing: border-box;
}
.mean-close {
  transform: rotate(270deg);
  padding: 0px 4px 0px 0px !important;
  margin-top: 2px;
}
.item-list .pager .pager-item:hover {
  border-radius: 3px;
  transition: background-color 300ms ease-out;
}
#sidebar .block {
  width: 100%;
  float: left;
  box-sizing: border-box;
}

Please take look into it.

Rather than to resolve the issue, i guess you removed the path from README.txt .

Configuration
-------------
Find the configuration of theme here: <strong>admin/appearance/settings/himalaya</strong>

Hi Sumit,

I found some more issues related to UI.

1. Huge space between footer and content (screenshot attached).
2. If main menus are disabled, design breaks (screenshot attached).

Please do a complete regression testing before review, so that more serious issues can be found.

Is there any updation in code ? Please do not change status everyday without getting any review.

If you want to speed up your own project through the review process, Please check this, and also you will learn a lot from this. The hope is that you will continue your involvement thereafter.

I took a quick look to it, and think it maybe be still need some updates, custom.js is still not using Drupal behaviours,

Hi Sumit kumar

I took a look to the themplate and tested agains a W3C validator. I found some errors that can be fixed, for example at page.tpl.php

<div id="footer">
  <div class="section">
    <?php if ($page['footer']): ?>
      <div id="footer" class="section section-full-colored">
        <div class="section-content center" >
          <?php print render($page['footer']); ?>
        </div>
    </div> <!-- /#footer -->
<?php endif; ?>
</div><!-- /.section -->
</div>
<!-- /#footer-wrapper -->

There are some scenarios in which the

id="footer"

will be printed twice, it will recommended that id will be print only once on the document.

Regards

Hi Sumit,
Thanks for your contribution!

I haven't had the chance to install this in a test site yet, but I read the code anyway.

- in your js/custom.js file, feel free to "$" inside the behavior function. You have already taken jQuery to the local scope. That will save may be half a kilo byte from the file size.

- Also, be careful when attaching behaviors. Usually we need to use the jQuery once plugin (comes with Drupal core) to prevent subsequent event bindings.

- are you sure the fonts you have included are GPL'd?

Removing review bonus tag, you have not done all manual reviews, you just posted the output of an automated review tool. Make sure to read through the source code of the other projects, as requested on the review bonus page.

I have checked on my machine but i did not get any issues and i have also checked on mobile resolution 320, 768,480.

I like the color scheme of the Theme. I found no issue with the Theme. Theme is easily configurable with drupal 7. Thanks for your contribution.

Hello,

Automated Review:
Please fix all error from pareview.sh
http://pareview.sh/pareview/httpgitdrupalorgsandboxsumitkumar2467223git

Manual Review:
README.txt/README.md
NO: Follows README Template.
https://www.drupal.org/node/2181737

Coding style & Drupal API usage
NO

-Please fix 2 "id" in logo

-Please check options what you show - you use, I not see in yours theme: "Site name", "Site slogan" - but you write - you use ?!
Please check all other yours theme settings.

-Please fix CSS

* {
  box-sizing: border-box;
}
.mean-close {
  transform: rotate(270deg);
  padding: 0px 4px 0px 0px !important;
  margin-top: 2px;
}
.item-list .pager .pager-item:hover {
  border-radius: 3px;
  transition: background-color 300ms ease-out;
}
#sidebar .block {
  width: 100%;
  float: left;
  box-sizing: border-box;
}

all tags what need special prefix for different browsers - so prefix need set.
as example:

  -webkit-transition: all 0.5s ease 0s;
  -moz-transition: all 0.5s ease 0s;
  -ms-transition: all 0.5s ease 0s  
  transition: all 0.5s ease 0s;

- Not understand what layouts your theme has is Responsive or Fluid layout?
These full different layouts, please fix that in THEME description.
yours images not support Responsive.

Thanks,

Hello,

Please check all what I wrote, please recheck, please fix

README.txt don't fix

CSS - don't fix

options - don't fix

your theme has is Responsive or Fluid layout? - don't fix

Your theme designer, so all theme setting must work and look excellent !!!!

Please no submit part errors fixed

Thanks

Thanks @sumit for contribution

http://pareview.sh/pareview/httpgitdrupalorgsandboxsumitkumar2467223git is clean now.

@Ordasoft Can you please elaborate this your theme has is Responsive or Fluid layout ?
All other changes looks good to me.

Hello,

your theme has is Responsive or Fluid layout? - don't fix (in Theme description on drupal.org)

README.txt - don't fix Follows README Template. https://www.drupal.org/node/2181737

CSS - don't fix -
as example for

.mean-close {
  transform: rotate(270deg);
  -webkit-transform: rotate(270deg);
  -ms-transform: rotate(270deg);

Please check all so CSS styles

Thanks

README and CSS improvements are surely not application blockers, anything else that you found or should this be RTBC instead?

Hello,

Responsive and Fluid - that full different layouts. Now theme work like responsible, so owner must remove Fluid layout from description

CSS - as me seem important for theme.

Readme Template - also drupal org requirements.

All other good for me.

Thanks

thanks @Ordasoft !!

@sumit Please remove fluid layout from description.

Also It would be god If you can add @file comments in CSS files. Please refer https://www.drupal.org/node/1887862#comments

Other changes are looks good to me.

@sumit Please do these changes, I am setting it to RTBC so that @klausi can take a look into it.

Hello

fluid layout continue exist in theme description - not fixed

https://www.drupal.org/node/2470681#comment-10031661

Thanks

Thanks @Sumit, looks good now. Please wait for @klausi's final review.
Also please add new review bonus :)

Review of the 7.x-1.x branch (commit 3e8671a):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/template.php
  ---------------------------------------------------------------------------
  FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
  ---------------------------------------------------------------------------
   1 | WARNING | No PHP code was found in this file and short open tags are
     |         | not allowed by this install of PHP. This file may be using
     |         | short open tags but PHP does not allow them.
  ---------------------------------------------------------------------------
  

• Codespell has found some spelling errors in your code.
  

  ./css/style.css:282: Calender  ==> Calendar
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. The project page misses a screenshot. Or is this a base theme that is meant to be overridden? What are the differences to existing themes like omega, bootstrap, zen etc. then?
2. Is the template.php file actually needed? If not it can be removed, otherwise please add the PHP tag and explain why this file is empty.

But otherwise looks good to me.

Thanks for your contribution, Sumit kumar!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Congratulation @Sumit !! Keep contributing and Keep up your good work.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2517820

Project 2: https://www.drupal.org/node/2470681

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Let's leave this at fixed