[D7]Currency taxonomy

the git clone command that you must show is "git clone --branch 7.x-1.x https://git.drupal.org/sandbox/nehapandya55/2683879.git currency_taxonomy"

your project status must be a "needs review" to be reviewed by the community

I installed the module and i got this notices:

- Notice: Use of undefined constant currency - assumed 'currency' in _currency_taxonomy_create_taxonomy() (line 944 of /var/www/html/test/sites/all/modules/currency_taxonomy/currency_taxonomy.module).
- Notice: Use of undefined constant currency - assumed 'currency' in _currency_taxonomy_create_taxonomy() (line 961 of /var/www/html/test/sites/all/modules/currency_taxonomy/currency_taxonomy.module).
- Notice: Use of undefined constant currency - assumed 'currency' in _currency_taxonomy_create_taxonomy() (line 982 of /var/www/html/test/sites/all/modules/currency_taxonomy/currency_taxonomy.module).

And the vocabulary doesn't been created.

Notice fixed.
Currency vocabulary created but with first term empty.

Automated Review

No issues here.

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

[Yes: Meets the security requirements. / No: List of security issues identified.]

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. Looks fine for me
2. While enabling module,it take time to get configured. Assuming the time taken to add all terms.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Hi nehapandya55,

I manually tested this module and its working fine for me.

There is no major blocker found.

One recommendation:

1. Please add hook_help() in your module which is helpful for developers that what this module did.

Thanks for your contributions.I would suggest you to take a review bonus to speed up the process. Please help reviewing and put yourself on the high priority list, then one of the Git Admin will take a look at your project right away :-)

Up next.

Automated Review

Review of the 7.x-1.x branch (commit 39d1f47):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Manual Revew

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity. Squeaks by. Not going to quibble on this.

Secure code

Don't see anything wrong.

Coding style & Drupal API usage

I think your enable/disable hooks may need more more error checking as these run each time a module gets enabled and disabled.

currency_taxonomy_disable(), do you really need the field_purge_batch()? If other fields qre queued up, this may nut behave as expected?

_currency_taxonomy_add_terms(), why the utf8_encode(). Comment needed.

Not sure how this will really work out in a multilingual system.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

This module barely meets the minimum standards for code length, but does demonstrate knowledge of the Field API. I am not seeing any blocking issues here (any bugs would not be blockers). Sending to @heddn for a second opinion / look.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Looking at this now.

manual review:

1. project page: what is the use case of this module? Why would I need it? Should I use this alongside Drupal Commerce? Does the module only provide the taxonomy or has it any other functionality? Please fill out the project page according to https://www.drupal.org/node/997024
2. The 8.x-1.x branch needs some code formatting, see http://pareview.sh/pareview/httpsgitdrupalorgsandboxnehapandya552683879g...
3. currency_taxonomy_enable(): use hook_install() instead. You only want to create your taxonomy data once - when the module is first installed. Same for currency_taxonomy_disable(), that should be hook_uninstall().

The biggest question for me is why I would use this module when I can simply have a CSV dataset that I import with https://www.drupal.org/project/taxonomy_csv whenever I need it.

But since the module demonstrates just enough Drupal knowledge I think we can approve you.

Thanks for your contribution, Neha!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.