[D7] Node Asset

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxweekbeforenext1993962git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Code format comments:

File : node_asset_index.admin.inc

Line 49: Potential problem: FAPI elements '#title' and '#description' only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized.
'#description' => $description,

Solution : Please remove P tags, it doesn’t require in description. If no please use check_plain

File : node_asset.filters.inc

Line 159: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(),filter_xss() or similar. (Drupal Docs)
drupal_set_message(t('The placement of Node Asset "' . $node_asset->title . '" cannot be fully rendered because it causes an infinite render loop. See Error'), 'error');

Solution : Please use l() function to generate links ( a tags)

Line 166: Potential problem: drupal_set_message() only accepts filtered text, be sure all !placeholders for $variables in t() are fully sanitized using check_plain(),filter_xss() or similar. (Drupal Docs)
drupal_set_message(t('There is a Node Asset placed that cannot be found in this site. See Error'), 'error');

Solution : Please use l() function to generate links ( a tags)

Hi,

Manual Review

I found you have added CSS file in hook_init. hook_init gets called in every page and its called in every ajax request. You can add this css file in other place. Refer this https://www.drupal.org/node/171209

/**
 * Implements hook_init().
 */
function node_asset_init() {
  drupal_add_css(NODE_ASSET_MODULE_PATH . '/css/node-assets.css');
  drupal_add_css(NODE_ASSET_MODULE_PATH . '/css/node-assets-library.css');
}

Hi weekbeforenext ,

I review your module there is number of errors which is reported number of errors by preview.sh. Firstly you have to resolve that errors.

Manual Review

I found you used helper function named

1. node_assets_set_wysiwyg_modes
2. node_assets_set_default_wysiwyg_mode
3. node_asset_node_type_save
4. node_asset_is_node_asset_content_type
5. node_assets_get_types_list
6. node_assets_get_types
7. node_asset_is_popup
8. node_assets_get_placeholder
9. node_asset_html_delivery
10. node_assets_pre_render_text_format
etc..

All helper functions should be prefixed with your module name.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.