[D7] Feeds ECK Processor

Automated Review

Please See: http://pareview.sh/pareview/httpgitdrupalorgsandboxandruxa2301489git

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

No: List of security issues identified in file: plugins/FeedsECKprocessor.inc

1. 273 | WARNING | Possible SQL injection in db_query() via variable $table
2. 276 | WARNING | Possible SQL injection in db_query() via variable $table

Coding style & Drupal API usage

List of identified issues in no particular order:

1. Remove "version" from the ./feeds_eck_processor.info file, it will be added by drupal.org packaging automatically.
2. Expected 1 newline at end of file
3. Missing file doc comment
4. Missing function doc comment
5. Missing class doc comment
6. Whitespace found at end of line
7. ...

Hi,

Please ensure that you add your sandbox URL to the issue.

It seems you haven't added README file for the project. There are some more issues arouse in Pareview.sh check it out and fix those.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Hello!

1. We edited code to correspond to Drupal Code Style.
2. Added license and readme.
3. Fixed possible SQL injection.
4. Added docs and comments.
5. Fixed issues for module.
6. Extended module description.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Please see:
http://pareview.sh/pareview/httpgitdrupalorgsandboxandruxa2301489git

Note that perfect adherence to Drupal Coding Standard is NOT a reason to block an application, except for total disregard of them. However, modules should follow them as closely as possible.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

No: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. Please add hook_help() in your module which is helpful for developers that what this module did.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

function feeds_eck_processor_enable() {
  // Clear the cache to display in Feeds as available plugin.
  cache_clear_all('plugins:feeds:plugins', 'cache');
}

You don't need to do this. Enabling a module clears all caches anyway.

Have you looked at https://www.drupal.org/project/feeds_entity_processor? Does that not cover ECK entities?

I see this issue has been commented on and reviewed but not set to 'Needs Work'.

As the review in #6 states, the README.(md/txt) needs looking at, along with the code complexity of the project.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.