[D7] Webform Submissions Bulk Delete

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, Few Things:
1) It is recommended to always implement hook_install(). Here you can find an example.
2) configure link is missing in your .info file.

Hi, i feel even if you are not using any tables you still need to add a installation message in your hook_install, so that it confirms that module gets installed properly.
Please have a look at the link i posted in earlier message.

Thanks

Hi viswanathan6,
1. For adding the Pareview bonus tag, you need to review three other projects.
When done, add them to your sanbox front page.
Also, as your project had been rolled back to "Needs Work" after adding the Pareview Bonus tag, so it should be removed according to Drupal Rules. Review three other projects again,and set back the tag. Removing it for a while.
2. In the README, no need to add D7 as a requirement.
3. Drupal already has the required version of php. See this https://www.drupal.org/requirements .
So you can safely remove the line php=5.3 from your *.info file.

And must say, excellent work buddy. It works for me. Didnot find any major application blockers.

Automated Review

Git default branch is not set, see the documentation on setting a default branch.

Manual Review

Individual user account

Yes: Follows.

No duplication

No: date range export exists in last recommended version of webform.
But deleting submissions by date range still not implemented in core module.

Master Branch

Yes: Follows. No Master Branch.

Licensing

Yes: Follows.

3rd party assets/code

Yes: Follows, no 3rd party code.

README.txt/README.md

Yes: Follows. But, README.txt template sugest to use "INTRODUCTION" instead of "DESCRIPTION".

Code long/complex enough for review

Yes: Follows.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage.

1. (*) Your module should inherit the the functionality of parent module and expand the DOWNLOAD RANGE OPTIONS section on node/nid/webform-results/download (download tab) so the user can use other options when downloading the results (columns, format, ets.). I think this is a major issue which must be fixed before the release.
2. (+) Delete submission. To follow drupal way, you have to use Drupal confirmation page instead of JS alert window. Here you can find some "how to" build the confirmation page.
3. (+)
   

   webform_data_export_menu().
   

   
Better to use

   
'page callback' => 'drupal_get_form',

   'page arguments' => array('webform_data_export_submission_form')

   

   Instead of
   


   
'page callback' => 'webform_data_export_submission_form',

   

   


   So that no need to write extra call to drupal_get_form(), drupal will do that for you.

4. Check the spelling in webform_data_export_install().

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

OK, I will check.

Bad news @viswanathan6.
I started testing your last changes, and updated webform module to latest recommended version: 7.x-4.10, where downloading by date range already implemented ((((.

Good news is that deleting by date range still not implemented there, so you can add this, but my recommendation is to create a patch for webform (if one is not exists yet).

As the Webform maintainer haven't accept the patch (https://www.drupal.org/node/2540330), and he also suggests to make it as an add-on module. I think this should be reopen again.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Hey, viswanathan6, I think you have to remove "_d7_" prefix from module folder name. What is the reason to add it?

Automated Review

Git default branch still is not set. Setting a default branch

Manual Review

Individual user account

Yes: Follows.

No duplication

No: This module expands the webform functionality.

Master Branch

Yes: Follows. No Master Branch. But default branch is not set, please set the default branch.

Licensing

Yes: Follows.

3rd party assets/code

Yes: Follows, no 3rd party code.

README.txt/README.md

Yes: Follows. But need to fix module name in Installation section

Code long/complex enough for review

Yes: Follows.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage.

1. (*) no validation when the start date greater than end date. Need to add.
2. (*) no date format validation. I can enter any string in the date fields and form still asking me "Warning, this is the last step before form gets submitted" "Process?" Form must validate date format before process to next step. Move this $end_date = strtotime($end_date)) !== FALSE to form validation.
3. (*) Call to webform_submissions_bulk_delete_webform_submission_action() on line 138 use 3 parameters, but function definition use 2 parameters.
4. (+) webform_submissions_bulk_delete.info:
   No need to define configure = node/%nid/webform-results/bulk-delete. This is not a configuration page. Remove this line.
   stylesheets[all][] = css/webform_submissions_bulk_delete.css: Better to attach you CSS file especially for page where it is used.
   Use $form['#attached']['css'] to attach your file instead of drupal_add_css().

   Even more, I think CSS code from webform_submissions_bulk_delete.css is not used any more. Please review this file, probably it can be removed from the module.

5. The date picker removed. I suggest to add it back, this can help to avoid date format misunderstood for users.
6. I also suggest to expand existing "Clear" page with adding additional option to delete submissions range instead of building separate page for this.
7. Feature request: Add VBO action to perform selecting and deleting submissions on "Submissions" tab since now this is views page. Module definitely can release without this, but in future it will be good to have this functionality.
8. Feature request: Delete by ID range. Module definitely can release without this, but in future it will be good to have this functionality.
9. Make Date popup dependency optional with keeping date format validation (currently it is provide by date module).

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Module looks good for now, setting status RTBC.
Also, I want to make additional feature request:
make Date popup dependency optional with keeping date format validation (currently it is provide by date module).

Thank you for your contribution!

I am going to update your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions
• Helping maintainers in the issue queues

You can find more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thank you, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thank you to the dedicated reviewer(s) as well.

Have you changed the project name?

Reviewing this...

Hmm. Strange. Really, on https://www.drupal.org/project/webform_submissions_bulk_delete/git-instr... , I see:

git clone --branch 7.x-1.x http://git.drupal.org/project/2543296.git
cd 2543296

I can't help here.

You also should set tag in GIT and setup default recommended release to display download links on project page.

Maybe the problem exists since you had changed the project GIT url?
Tried to contact directly to somebody from drupal team via Email?

I didn't face with problems like this when my project was promoted few days ago.

@viswanathan6: you are still trying to push to the old sandbox URL. You need to update your git remote URL or reclone the project from the new URL.

You delete the folder of your module on your computer and run the instructions from https://www.drupal.org/project/webform_submissions_bulk_delete/git-instr... again.

It's git clone --branch 7.x-1.x viswanathan6@git.drupal.org:project/webform_submissions_bulk_delete.git.