[D7] Peytz Mail

Git command is not working for non-maintainer users.
You have to visit version control settings and uncheck "Maintainer?" checkbox in order to get the right git command.

Instructions updated.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2541320

Project 2: https://www.drupal.org/node/2522976

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxkoykov2538530git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Please check with Coder Module

There are notices and warning

Hi koykov,

Found 2 errors on /admin/config/peytz_mail/settings page

a) Connection timed out. Please check your Service URL.
b) Notice: Undefined variable: data in peytz_mail_get_mailing_lists() (line 368 of D:\xampp\htdocs\responsivewebsolutions\sites\all\modules\peytz_mail\peytz_mail.module).

Hi,

Use db_select instead of db_query in your .module file.

@viswanathan6: In general that advice is wrong. db_query() is preferred over db_select() for simple static queries, see https://www.drupal.org/dynamic-queries [1] . Or does the query need a dynamic part such as a node access tag? Please always add the reason why people should use db_select() instead.

Hi,
Manual Review

Getting following issues in the setting page.

Connection timed out. Please check your Service URL.
Notice: Undefined variable: data in peytz_mail_get_mailing_lists() (line 368 of /var/www/test/drupal_mi2/sites/all/modules/custom/peytz_mail/peytz_mail.module).
Notice: Undefined index: newsletter_lists in peytz_mail_settings_form_submit() (line 66 of /var/www/test/drupal_mi2/sites/all/modules/custom/peytz_mail/peytz_mail.admin.inc).
Notice: Undefined index: hide_newsletter_lists in peytz_mail_settings_form_submit() (line 67 of /var/www/test/drupal_mi2/sites/all/modules/custom/peytz_mail/peytz_mail.admin.inc).

Automated Review

Remove "version" from the ./peytz_mail.info file, it will be added by drupal.org packaging automatically

Manual Review

Individual user account

Yes: Follows guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements

Coding style & Drupal API usage

• (*) If you use variables, you have to erase them on uninstall. You may follow this: https://www.drupal.org/node/2274697

Module seems to implement Drupal guidelines, but the API call can't be made to test it.

• - Connection timed out. Please check your Service URL.
• - Notice: Undefined variable: data in peytz_mail_get_mailing_lists() (line 364 .../peytz_mail/peytz_mail.module).

For now you can put something like this, before line 364:

    if (!isset($data)) {
      return;
    }
  

To prevent PHP error from showing up.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2522976

Project 2: https://www.drupal.org/node/2541320

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.