[D6] Instafeedjs

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxachton2292317git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Thanks for the module!

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) Using hook_init you will add your js code on each page request, even if the page didn't have insta block
2. (*) Line 55: nothing to break here. Unnecessary else statement
3. (+) Line 139:function instafeedjs_js
   Php code generates html - it's not a good practice, you needs to use drupal_add_js function to add your js, and create js behavior to set variables from js (not php).

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Review of the 6.x-1.x branch (commit 95f5ce1):

• DrupalPractice has found some issues with your code, but could be false positives.
  

  
  FILE: /var/www/drupal-7-pareview/pareview_temp/instafeedjs.module
  ---------------------------------------------------------------------------
  FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
  ---------------------------------------------------------------------------
   220 | WARNING | #options values usually have to run through t() for
       |         | translation
   221 | WARNING | #options values usually have to run through t() for
       |         | translation
   222 | WARNING | #options values usually have to run through t() for
       |         | translation
  ---------------------------------------------------------------------------
  
  Time: 62ms; Memory: 5.25Mb
  

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Source: http://pareview.sh/ - PAReview.sh online service

Manual Review:

• Add help_hook() to the module
• Please update the project page as per the guidelines https://www.drupal.org/node/997024

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2541320

Project 2: https://www.drupal.org/node/2522976

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

While it is true that both those issues were opened by koykov (my colleague), the repo for Instafeed is actually mine, and so is most of the code in it. He has been helping me getting the repo approved so that module could be promoted to full.

So I have reopened this task, and someone with power might wish to assign this node to myself, if that is what determines which user gets the approval. I had the impression that the owner of the repo would receive the approval, not the owner of the application node.

Anyway, the repo is still fully up-to-date according to the latest review comments and IMO ready for real usage: https://www.drupal.org/sandbox/achton/2292317

/Achton

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2522976

Project 2: https://www.drupal.org/node/2541320

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

It seems the approval not going to happen with this project, so I am closing this application.