[D7] User Password Check

Hi,

Thanks for the work on this module.

. The string translation dt() function is missing in the user_password_check_drush_command() 'description' and arguments array 'users' data. It is recommended to use dt() for string inputs.

. hook_drush_help() is missing from the user_password_check.drush.inc. It is recommended to provide help to the drush command.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi
I reviewed you project it looks fine

1) It is recommended to always implement hook_install(). Here you can find an example.

Hi, few things

Add introduction part your README.txt about your module
Use db_select instead of db_query in user_password_check.drush.inc file

File : user_password_check.drush.inc
Line 52 :

Please add Function parameters - @param

/**
 * Check user password.
 * @param $users
 *   List of user objects
 */

refer : https://www.drupal.org/node/1354#param

Line 55 :

Please add a comment that what exactly you are trying to get.

Line 57 :

Please add a comment that what exactly you are trying to get.

Line 60 :

Please add a variable reference & pass it to foreach. It will be more readable (If you agree :) )

Line 66 :

I don’t find you where defined these function _drush_user_get_users_from_options_and_arguments().

Line 71 :

Please fix @viswanathan6 comments, I will recommend you to use EntityFieldQuery
Ref : https://www.drupal.org/node/1343708

Line 87 :

You are using drupal core function, Please add a comment that what exactly you are trying to get.

Line 102 :

You are using drupal core function, Please add a comment that what exactly you are trying to get.

Attached patch, Please look into changes

Agree, Thanks for correcting me :)

Hello @pablitt.
Manual Review
1)

$user_list = db_query("SELECT u.uid, u.name, u.pass 
      FROM {users} u 
      LEFT JOIN {authmap} a ON u.uid = a.uid
      WHERE u.uid > 0
      AND u.status = 1
      AND a.uid IS NULL")
      ->fetchAll();

Please use correctly static query static queries
2) Not working command drush user-password-check @user_name@ write Missing required options: --password-files, --block-user. See `drush help user-password-check` for information on usage. You have written that in readme.txt command can be used with a single argument.
3) Remove the line

$ git clone --branch 7.x-1.x http://git.drupal.org/sandbox/pable/2534886.git 
      user_password_check

in redme.txt because when your project will be full it is not useful
4) Not found functions

_drush_user_get_users_from_options_and_arguments($users);
drush_log();
drush_get_option();
dt();

One more suggestion for implementation:
I am not sure whether you should be using version specific drush commands.
You have dependency on drush 6.x, but now for majority of users might have updated their drush versions to 7.x or 8.x
Because only Drush 8 allows to work with Drupal 8 related sites.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.