[D7] Bulk Select

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxChrisGillis2512634git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
Automated Review
Used Coder Module.
Manual Review
Individual user account
Yes : Follows
No duplication
Yes : Follows
Master Branch
Yes: Follows
3rd party assets/code
No: Not applicable
README.txt
Yes: Follows
Issues
Feature: Collapsible doesn't work.
Same Collapsible issue is happening in your demo module as well. "Client 1 is not getting displayed properly". When we click on it, it should show the children, which is not happening.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Individual User Account?
Yes: Poster is following the guidelines for an individual user account.
No duplication?
Not really, it looks like the author has put posted in detail how the module contrasts against currently available projects, he’s definitely researched it.
Master Branch?
Yes: Default branch is set to 7.x-1.x
Licensing?
Licensing looks to be correct.
3rd party assets/code?
No, I don’t see any 3rd party assets or code.
README.txt/README.md?
README.txt is present.
Code long/complex enough for review?
Yes, there’s definitely enough code here to meet the guidelines for project length and complexity.
Secure code?

Coding style & Drupal API usage?

(+) Issue: Provided example is not functioning properly for me either (ChromeOS Pixel Laptop, Chrome). Client 1 is a link but does not expand, Client 2 is expanded but is not a link to contract (Screenshot attached). I have a couple of other project applications installed but nothing too complicated.

Recommendation: I was really confused on how to achieve the hierarchy when I tried to enter a select field using this widget. I would recommend putting some commenting in both the README and the example to describe how this is done.

I'm marking as needs work due to the broken example and not having clear direction on achieving the same results of the example on a custom field.

I like the idea, this is definitely going to be a useful module.

There's a javascript error for those who don't have jquery_update. This could be added as a dependency.

This is really nice little widget that I can see being very handy! The demo module shows both the Form API element and the Field Widget (in the install file), both of which give clear examples of how to use this. I agree that once this is a proper module, some documentation would make this a little easier to find.

One suggestion for an improvement is that if #expand_selected is set to TRUE and you then click on a parent option, it feels like it should open up all the way to the lowest children. Currently, it only goes one level deep with the expansion (see attachment) and not to, say, its grandchildren.

I won't re-iterate what has been said above in terms of reviewing, except to add that I've had a brief look through the code and it looks pretty tight.

Good work!

Hi,
1. Please check coding standard - http://pareview.sh/pareview/httpgitdrupalorgsandboxchrisgillis2512634git
2. bulk_select.module:129 - This code is required here?

    if ($key === 0) {
      $key = '0';
    }

3. How i can add field with hierarchy using this widget from admin panel?

Thanks for your work!

Thanks for your contribution, Chris!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.