Comments

podarok’s picture

Title: Drupal 8 port for » Drupal 8 port for Location module

title fix

vladbo’s picture

Issue summary: View changes

Hey :)
Is there any progress with porting module to D8?
Maybe we can help you with it?

podarok’s picture

I`ve already started gmap porting to D8
http://drupalcode.org/project/gmap.git/tree/refs/heads/7.x-2.x:/lib/Drup...

And any help will be appreciated in gmap and location modules
The roadmap #2139223: Drupal 8 gmap version

Idea is to convert all the configs and services to singletons(configs) and factories(services) for D7 versions, test it and after that create initial D8 releases with integration into D8 infrastructure

bnthms88’s picture

How are things going here? Would be interested in learning more and helping out!

Ben

marc.groth’s picture

I have started to move the code across to D8 and while I knew the Location module was big, I didn't realise it was this massive! It's going to take some time... With that said, may I suggest we implement all changes in a Git repo (happy to provide access if others think they'll be able to help out) in the interim and once we're happy/feel it's in a stable enough state we provide it here as one final patch? Otherwise it's going to get messy with many patches.

If anybody thinks they will have time to help port the functionality then let me know and I can open access to the repo. If and when it does come to that it may be worth splitting the tasks up so we don't double up on work... At the moment I'm focusing on the core Location module; but there are of course many sub-modules within that that could be moved across. In short, there is plenty of work :)

marc.groth’s picture

Assigned: Unassigned » marc.groth
RaulMuroc’s picture

I can give a hand of some of the sub-modules. Not a lot of time, but will find it out.

Blumode’s picture

Any news for location module 8.x ?

marc.groth’s picture

I started to port the Location module over to D8 but this was 6 months ago (back when Drupal was still in beta6) so it's likely that a lot of what I've done is no longer relevant/changed etc.). I haven't had a chance to look at it since then.

If you are interested and want to contribute/start moving this along again then you can see what I've done so far and download the repo here: https://bitbucket.org/grothm/location/

I will try and get back into it when things calm down a bit but in the meantime feel free to get stuck in.

Cheers,

Marc

infopicard’s picture

Hello,

now release candidate has been released. Is there a plan, when location and gmap module are available for drupal 8?
We need it for our drupal site for migration from 6 to 8.

If you need help (I'm not a developer) but for testing, please feel free to ask. Thank you!

Melvin Loos’s picture

I am working on a side-project in my spare time and this module might be very crucial in its success so I will have a more detailed look as soon as I can and possibly contribute some work and time in it. I have however still some learning to do in Drupal 8 but I have a lot of experience in Symfony and its components so that should not be a big blocker.

I assume there is not much documentation for this module's rewrite available to get me going? The repo doesn't have a README for as far as I can tell.

podarok’s picture

Hey, dear all
Right now documentation for the project is stored within code.
And if we are talkign about D8 port - here is a simple roadmap

  1. - Architecture inventory (features list)
  2. - Decide what features should be implemented as D8 services
  3. - Implement all services
  4. - Implement location field.
podarok’s picture

Issue summary: View changes
podarok’s picture

Issue summary: View changes
andypost’s picture

Category: Task » Plan
Issue summary: View changes

Also added upgrade path
Suppose each issue in IS needs separate oneso converted this

jacov’s picture

do we have a plan and ETA for location module on d8 ?

this module is critical to many location based applications moving to d8.

(will try to get more help for this...)

abhishek-anand’s picture

I will be working full time to port this module to D8 in next few weeks.
I am taking forward the work done by marc.groth at https://github.com/fly2abhishek/location

podarok’s picture

Assigned: marc.groth » ddrozdik

@abhishek-anand it is not a good idea to work for location
We've started to move to dmaps https://github.com/drupal-ukraine/dmaps. Let's collaborate there
Ping @ddrozdik about details

infopicard’s picture

@podarok & @abhishek: Perhaps its a good idea to combine your effort in port location/gmap -> dmap

Please don't forget a solution for migration of existing location data from D6 - that is a very important requirement for our migration.
it is also very useful to integrate taxonomy specific marker on map.

If I can assist in testing, please don't hesitate to ask me.
Thank you very much and I'm looking forward to a great solution.

makbul_khan8’s picture

Hi @abhishek-anand,

Your git repo seems to be updated a year back, should I commit the latest changes that we got after running drupalmoduleupgrader?

Yes combining module location/gmap -> dmap is a great idea. Please consider me in for this D8 module porting.
We also need a roadmap to merge both these module and the part need to migrate & not to migrate from existing D7.

Thanks

abhishek-anand’s picture

Hi podarok,

Thanks for the details. We will now collaborate with @ddrozdik to get involved with dmap.

Thanks

kaizerking’s picture

Microformat D8 is available now probably it will help Location address microformat

joachim’s picture

The current code from bitbucket crashes with: Fatal error: Cannot instantiate interface Drupal\Core\Cache\CacheBackendInterface

The fix is the same as for similar issues in other modules -- see #2564717: Fatal error: Cannot instantiate interface Drupal\Core\Cache\CacheBackendInterface for example.

mcgovernm’s picture

How can I get involved in this? Where is the most up to date code? and is there an issue queue, or task list of outstanding items?

alabandit’s picture

I am also interested in this port. Possibly keen to get involved depending on what is needed?

https://github.com/drupal-ukraine/dmaps/tree/8.x-1.x/d8/modules/custom/d...

It does not seem like it has been updated in 3 Months.

What's the best way to get involved?

afi13’s picture

Port of this module is no longer necessary, because of other stable solutions:
https://www.drupal.org/project/address - perfect address storage
https://www.drupal.org/project/geofield - perfect location storage
https://www.drupal.org/project/geocoder - automatically geocode Address to Geofield

mvdve’s picture

https://www.drupal.org/project/geolocation Is also an excellent alternative. Much more lightweight then the whole geocoder stack.

drupgirl’s picture

Hi, I'm migrating a d6 -> d8 site that heavily uses the location mod. What's the progress with this? Anyone worked this through? Thanks!

awasson’s picture

I suspect one could write a custom YML file to map Location fields to Address fields prior to running the migration and then all of your valuable data will be safe and sound.

In my experience this is best tested locally with a stripped down version of the D8 site and a copy of the D6 database. It can be tedious to do but will provide valuable insight for the real migration.

EDIT: I'm suggesting Address as the successor for the location module in this D6->D8 scenario because I have done a similar project where we moved from Location to Address. Address wasn't ready when we did ours so it was a messy process. Moving forward I would adopt the strategy I suggested in this post.

nhaarish’s picture

Issue summary: View changes

@podarok, @ddrozdik: Any update on this D8 release. I would like to help for porting to D8. Kindly let me know from where I can get the latest code. There has been no commits in https://github.com/drupal-ukraine/dmaps for past 1 year and 6 months.

mgifford’s picture

Other than migration from older code (which is a pain), is there anything that can't be done with these existing D8 modules:

https://www.drupal.org/project/address
https://www.drupal.org/project/geofield
https://www.drupal.org/project/geocoder
https://www.drupal.org/project/geolocation

If not, then let's update the project description to make it clear that there isn't a straight upgrade path for Location to D8.

podarok’s picture

There is no any update of the module for Drupal 8
Current state - we tried to merge efforts and created https://github.com/drupal-ukraine/dmaps
But even this made not so much progress so far
So in case if anybody interested - please let me know ( use contact form ) and I'll add you to dmaps project on GItHub

joshua.boltz’s picture

The piece I think that is missing from all of those solutions currently available in D8 is the ability to do proper location proximity, as was available in D7 Location module.

Geofield
Geolocation
Address
Geocoder

I've been able to get close to a configuration that works for location proximity, but from a UX, it makes no sense to ask a user to input a lat/long value for their location they want to search on. Instead, I want to allow them to enter a city, state, or zip, and use Geocoder to maintain the lat/long that is needed to do the actual proximity filtering.

If anyone has any tips on how they've got a good proximity filter solution in place in Views D8 with any of these modules or other modules, it would be appreciated.

bogdog400’s picture

Can anyone share the custom YML file for upgrading from Location (D7) to Address (D8)? I'm about to tackle this issue and any prior experience or advice would be most appreciated.

mylocaltrades’s picture

@joshua.boltz Did you manage to find a solution to the postcode search problem? I am currently where you were and looking at the same problem with the lat/long input!

I too am using the following modules to try to achieve a search using the address module:

Geofield
Geolocation
Address
Geocoder

DamienMcKenna’s picture

colan’s picture

#33: This was recently implemented in Geofield in #3012750: (New) Drupal 8 Geofield Proximity View (Field, Filter and Sort) Handlers System, but it's also possible to do it with Geolocation Field. Both of these are listed in #31.

ccjjmartin’s picture

For anyone following up on this I like the approach of splitting this module up into is parts, addresses and geofield data. So I have patches and documentation for the migrations I did:

Address: https://www.drupal.org/project/address/issues/2974631#comment-13816987

Geofield: https://www.drupal.org/project/geofield/issues/3170032

eit2103’s picture

Wondering if any progress.

Wim Leers’s picture

I can't believe I've not found this issue previously … we've contributed a module that automatically migrates everything used in Location in D7 to equivalent address and geolocation fields in Drupal 9, with absolutely zero data loss: https://www.drupal.org/project/location_migration.

colan’s picture

Component: Code » Documentation

Excellent! (I was wondering what folks were up to post-D7.) Let's deprecate this project for D8+ on the project page then.

colan’s picture

Status: Active » Needs review
DamienMcKenna’s picture

That's incredible, thanks Wim (and Huzooka!).