Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The Date All Day module exists to provide the capability to make "time" optional on date rage fields. In other words, to indicate that a date covers "all the day". A similar module already existed in Drupal 7, as part of the date module, but not in Drupal 8 and upper.
The module provides a field widget and some field formatters for the core's daterange field.
Similar modules
- Smart Date - Provides a complete framework to manage dates, including "all day" dates functionality and provides its own field type. Date all day instead focuses on providing only the all day functionality to core fields
Comments
Comment #2
akalam CreditAttribution: akalam at Dropsolid commentedComment #3
shashank5563 CreditAttribution: shashank5563 at Melity commentedThank you for applying! Reviewers will review the project files, describing what needs to be changed.
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
To reviewers: Please read How to review security advisory coverage applications, What to cover in an application review, and Drupal.org security advisory coverage application workflow.
While this application is open, only the user who opened the application can make commits to the project used for the application.
Reviewers only describe what needs to be changed; they don't provide patches to fix what reported in a review.
Comment #4
vishal.kadamComment #5
apadernoI am assigning this issue.
Comment #6
vishal.kadam1. Fix phpcs issue.
2. FILE: date_all_day.info.yml
core_version_requirement: ^8 || ^9 || ^10
The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement: key.
Comment #7
akalam CreditAttribution: akalam at Dropsolid commentedThanks for your review. The requested changes have been fixed on the 2.0.x branch, could you review it again?
Comment #8
vishal.kadam@akalam,
I have reviewed the changes, and they look fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
Comment #9
akalam CreditAttribution: akalam at Dropsolid commentedThank you so much :)
Comment #10
apaderno@vishal.kadam This issue was assigned to nielsaers because he should have done a review.
Comment #11
vishal.kadam@apaderno Apologises. I didn’t see that it was assigned.
Comment #12
apadernoComment #13
nielsaers CreditAttribution: nielsaers at Dropsolid for Dropsolid commentedPicking this one up today.
Comment #14
nielsaers CreditAttribution: nielsaers at Dropsolid for Dropsolid commentedHey akalam,
1. date_all_day.js:
I think you might be attaching multiple change events to the same elements. Every time behaviors get triggered you'll add your change listener to existing and new items alike. If it is the case, use once and the context to apply your logic: https://www.drupal.org/docs/drupal-apis/javascript-api/javascript-api-ov...
2. date_all_day.libraries.yml:
You define once as a dependency but you don't use it. See remark in 1.
The rest looks good! (Automated check didn't have any complaints other than the proposal to write some tests, but these aren't mandatory for this)
Comment #15
nielsaers CreditAttribution: nielsaers at Dropsolid for Dropsolid commentedComment #16
apadernoComment #17
vinaymahale CreditAttribution: vinaymahale as a volunteer and at SJ Innovation LLC commentedComment #18
apadernoComment #19
apadernoI am changing priority as per Issue priorities.