Last updated March 7, 2017.
- First and foremost it is strongly recommended that you review other project applications according to the review bonus program, then other Drupal developers will be eager to review your code.
- Reviewers will basically follow the pattern of the project application checklist.
- Your module or theme should demonstrate ingenuity and originality by the author.
Project Application Workflow
For detailed information on what to expect during the process, applicants are encouraged to read through the reviewer documentation section of this handbook. For the sake of convenience, the workflow steps are repeated below.
- The applicant submits their application to the Project Applications issue queue, complete with a link to their Git sandbox repository which will contain the module or theme code.
- When the applicant has fully prepared his or her sandbox code and supporting materials, he or she should change the status of the issue to 'Needs review'.
- Other Drupal users will then review the module.
- If any issues are found:
- The reviewer will leave a comment in the issue thread, identifying the issue (and preferably explaining what needs to be done to address it), and set the issue status to 'Needs work'.
- The applicant should make the appropriate changes to the project (or answer any questions that are asked), and change the issue status back to 'Needs review'.
- The reviewer will validate the changes/response, and repeat the process if they identify any new issues and/or questions.
- Once all issues have been addressed:
- The reviewer will change the status of the issue to 'RTBC'
- After that, a 'git administrator' will validate the review, grant the applicant the 'Git vetted user' role, and change the status of the application to 'Fixed' (or set it back to 'Needs work' if new issues are identified).
Unfortunately, the application queue does occasionally experience a large backlog, and applications may sit in the queue up to a year before getting reviewed. You can avoid that by taking part in the review bonus program. In the event that your application has held a status of needs review for a certain length of time, applicants or reviewers may elevate the priority of the application. Once a reviewer has responded according to the project application workflow and the application review process proceeds the application priority should return to normal.
The guidelines for elevating application priority are as follows:
- Normal: All applications must begin with a normal priority. Applications with elevated priorities should be returned to normal priority once a reviewer has continued the application review.
- Major: Applications with a status of needs review that have been awaiting response from a reviewer for 2+ weeks.
- Critical: Applications with a status of needs review that have been awaiting response from a reviewer for 4+ weeks.
To get a sense of the current application backlog, check the date on the oldest application in the queue with 'needs review' status.
While you wait, consider joining the Code Review Group and contributing a few reviews of your own. Providing a solid review of another's work can help demonstrate your understanding of the Code Review principles just as effectively as your code itself, and some reviewers may be willing to help fast-track your own application when they witness you contributing to the code review effort.
A few Resources, shortcuts and templates for volunteers doing code review are maintained over in that group wiki.