Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
About:
The Check DNS module simply prevents user registration with an invalid email domain on the user registration form.
It validates the email domain before registration and checks if the domain exists. This prevents false registration.
Project:
https://www.drupal.org/project/check_dns
Git instructions:
git clone --branch 8.x-1.x https://git.drupalcode.org/project/check_dns.git
PAReview checklist :
https://pareview.sh/pareview/https-git.drupal.org-project-check_dns.git
Comments
Comment #2
baskaran CreditAttribution: baskaran commentedHi Gaurav_drupal,
Please fix the below change.
FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------
Comment #3
Gaurav_drupalThanks @baskaran for the review, fixed and pushed to 8.x-1.x
Comment #4
ashutosh.mishra CreditAttribution: ashutosh.mishra at iHorizons for iHorizons commentedComment #5
ashutosh.mishra CreditAttribution: ashutosh.mishra at iHorizons for iHorizons commentedThank you for applying! I modified the Git instructions for non-maintainer users and added PAReview checklist link.
Comment #6
shaktikThank you for your contribution!, Gaurav_drupal
bit optimization here
from
to
$mail = explode('@', Html::escape($mail));
the drupal check looks good.
check_dns drupal-check -ad .
2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
Comment #7
Gaurav_drupalThank you @shaktik for review. I have refactored and pushed the changes to 8.x-1.x
Comment #8
apadernoComment #9
klausiLooks good to me otherwise. Setting this to "needs work" because you need to know when to use Html::escape() and when not, but after fixing that I think we can approve this.
Comment #10
apadernoJust for helping to find the code that should not sanitize the method parameter, this is the code.
As side note, there isn't any need to put an empty line before the first code line of a function/method and after the last code line of a function/method.
Comment #11
Gaurav_drupalThank you @kiamlaluno @klausi for review and your invaluable suggestions. I have refactored and pushed the changes to the
8.x-1.x
branch.Comment #12
klausiThanks for your contribution, Gaurav!
I updated your account so you can opt into security advisory coverage now.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Thanks to the dedicated reviewer(s) as well.