[D7] Webform Tooltip

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I am reviewing this.

Thanks,
Rajeev

Automated Review

Review of the 7.x-1.x branch (commit c010a1a):

• ESLint has found some issues with your code (please check the JavaScript coding standards).

js/webform_tooltip.js: line 8, col 13, Error - Use the function form of "use strict". (strict)
js/webform_tooltip.js: line 9, col 3, Error - "xOffset" is not defined. (no-undef)
js/webform_tooltip.js: line 10, col 3, Error - "yOffset" is not defined. (no-undef)
js/webform_tooltip.js: line 13, col 27, Error - "yOffset" is not defined. (no-undef)
js/webform_tooltip.js: line 14, col 28, Error - "xOffset" is not defined. (no-undef)
js/webform_tooltip.js: line 21, col 27, Error - "yOffset" is not defined. (no-undef)
js/webform_tooltip.js: line 22, col 28, Error - "xOffset" is not defined. (no-undef)
js/webform_tooltip.js: line 27, col 24, Error - Use the function form of "use strict". (strict)
js/webform_tooltip.js: line 31, col 3, Error - "vtip" is not defined. (no-undef)

9 problems

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Source: http://pareview.sh/ - PAReview.sh online service

Manual Review

Individual user account
Yes: Follows.
Master Branch
Licensing
Yes: Follows.
3rd party assets/code
NO: Included third party library http://www.htmldrive.net/items/show/819/very-lightweight-tooltips-vTip
README.txt/README.md
Yes: Follows. But, please provide more descriptive information.

Code long/complex enough for review
Yes: Follows.
Just recheck the function description etc. also take care of grammer/spellings.

Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage.

Automated Review

Pareview.sh show some warnings - http://pareview.sh/pareview/httpgitdrupalorgsandboxmnfriend2179069git

Coder modules does not show any errors.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Follows guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

List of identified issues in no particular order. Use (*) and (+) to indicate an issue importance. Replace the text below by the issues themselves:

1. You should add hook_help to provide documentation about your module in the Drupal UI.
2. You should try to follow README Template page for your README.txt.

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

I do not see any blocker on this project. Well done @mnfriend.

@mnfriend: Now it looks fine.No any such blocker. Nice work..:)

Thanks for your contribution, Mohammed!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.