I believe the user pictures should not display the username in the alt text, rather they should display the display name.
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 2658602-24.patch | 1.67 KB | nikhil_110 |
| #8 | Issue-2658602-by-mstrelan-hass-User-picture-alt-text.patch | 1.71 KB | hass |
Comments
Comment #3
hass commentedCorrect.
Comment #4
xjmDiscussed with @Cottser. I think maybe we should combine these two issues, and also look at other uses of the username in core that should maybe be the display name instead?
Comment #5
xjm@Cottser also identified this other similar issue (already fixed).
Comment #6
effulgentsia commentedThis needs a test somewhere. There's still discussion in #2629286: Use getDisplayName() for user names consistently as to where.
Comment #7
hass commentedPlease provide an answer where.
Comment #8
hass commentedComment #9
dawehnerFor those tests we would need a different display name than the normal username. I'm quite sure that the test would pass without this bugfix.
Comment #10
hass commentedThat is why I started in #2629286: Use getDisplayName() for user names consistently to make sure this can be tested properly. We have troubles fixing some of the currently failing DisplayName tests in this referenced case. Maybe you can help?
Aside the DisplayName returns some HTML code. It is really not the same like the username.
Comment #14
nithinkolekar commentedas for the d7 if email_registration is enabled then it will exposes email id which I think is not good at all.
Comment #21
mstrelan commentedNeeds work as per #9
Comment #24
nikhil_110 commentedAttached patch against Drupal 95.x