RealName Drupal 8 port

I made some commits to D7 that fixes bugs. Please re-role with this changes so we do not run into regressions.

Created 8.x branch for you.

Needs re-role.

Just a quick review...

+++ b/realname.module
@@ -312,7 +242,7 @@ function realname_delete_multiple(array $uids) {
-  db_truncate('realname')->execute();
+  db_delete('realname')->execute();
   drupal_static_reset('realname_load_multiple');

That's not correct.

It looks like this patch removes Entity Reference support.

@tkulldeep17
Do you have some results for this issue
Can I try to develop porting patch for drupal 8.0.0-beta10?

So I'm reading about Drupal 8 module ports, and some of them say "partial" including media, and some others.

I think this is a wonderful approach to have basic functionality in core. If Token is going to be in core, then real name is an extension of token.

If we are going to hold up this port because of Entity Reference, then I think we should partially port it until we have the entity reference fixed. And I do not deny that entity reference is one of the things that makes Drupal great. As an intermediate Drupal developer, I mostly see it used by Organic Groups and Drupal Commerce, although I am always connecting the dots in new ways.

That goes to show it should be remedied, but it should not be a block. Right now, my one site uses it to send e-mail as a token, and real name's lack of readiness may prevent that port, which is hazardous given Drupal 6's soon to be end of life.

--Sam

TODO: Test if we really need the recursion protection validation any longer.

@webflo: Can you help reroling the missing parts, please? The code in the sandbox is such old... we need to check every line as a lot of things have changed and/or are no longer working because of core changes. The sandbox is also not based on the latest D7 code.

We may also rethink if we should rename the module to Display name. It does not give us anything real, but we follow the new naming of the display-name token.

Core has a bug

My apology when this is not the proper place. But I noticed, what I think is an error in the code of realname.module that seems easy to mend.

/**
 * Implements hook_ENTITY_TYPE_update().
 */
function realname_user_update(Drupal\Core\Entity\EntityInterface $account) {
  // Since user data may have changed, update the realname and its cache.
  $realnames = &drupal_static('realname_load_multiple', array());
  //$realnames[$account->id()] = realname_update($account->id()); /* Causes an error */
  $realnames[$account->id()] = realname_update($account);
}

The error according to the log was:
TypeError: Argument 1 passed to realname_update() must be an instance of Drupal\user\Entity\User, string given, called in C:\...\wwwroot\modules\realname\realname.module on line 110 in realname_update() (line 289 of C:\...\wwwroot\modules\realname\realname.module).

The 8.x-1.x branch seems to work relatively well, could this branch be set as supported so installing with composer is easily possible? Thanks!

No, it is not working properly. Please help getting the core issue RTBC and the open todo's fixed.

Waiting for the core issue to be committed before providing access to the development branch for a minor display issue is unreasonable from my perspective. It might block a stable release or maybe even a beta release but with the fixes now in the issue queue the module is at the very least a usable dev-branch.

The core issue is not a blocker. The module has errors and I asked for help, but until now, nobody tried to help.

@hass & Co, great work! But there's no tagged release yet, maybe keep this open until that?