Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
When editing a contextual filter in Views the options for absent argument are split by other form elements.
Steps to reproduce
Proposed resolution
Add a margin to the sub category in the contextual filter.
Remaining tasks
Margin does not apply when editing an existing contextual filter.
Review
Commit
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | Applied Patch 2167925.png | 110.46 KB | chetanbharambe |
| #15 | After Patch 2167925.png | 459.11 KB | chetanbharambe |
| #15 | Before Patch 2167925.png | 463.72 KB | chetanbharambe |
| #13 | After patch.png | 103.78 KB | mitthukumawat |
| #13 | Before patch.png | 104.4 KB | mitthukumawat |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedComment #2
dawehnerWell I think this is okay, the problem is something different, as we have no indentation or visual css that this is some subconfiguration.
Comment #11
LendudeYeah, I think we just lack some visualisation that this is subconfiguration
Checked if this got picked up in #3066006: Convert Views UI to new design system but alas, no.
This could just be as simple as adding a bit of a margin I guess.
Screenshot taken in
ClaroSevenComment #12
LendudeNow with a non-empty patch
Comment #13
mitthukumawat CreditAttribution: mitthukumawat as a volunteer and at Zyxware Technologies for Drupal Association commentedI have tested #12 in seven theme and after patch applied, the margin added and form elements appearing fine in contextual filter settings.
Comment #14
guilhermevp CreditAttribution: guilhermevp at CI&T commentedApplied patch #12 but was unable to see changes. Maybe I'm doing something wrong. Cleared cache multiple ways to no success.
Comment #15
chetanbharambe CreditAttribution: chetanbharambe at QED42 for Drupal India Association commentedPatch #12 applied successfully but I am not able to see changes on the 8.9.x version.
I have cleared the cache so many times but still not able to see the updated changes.
Here are the screenshots for reference.
Comment #16
quietone CreditAttribution: quietone as a volunteer commentedCame to review.
The issue summary is lacking and there aren't steps to reproduce not a proposed resolution. It wasn't until I looked at the screenshot in #11 that I figured it out. Added the template and some screenshots.
I applied the patch and like guilhermevp I did not notice any change. After some playing around I found that this works when adding a new contextual filter. When editing an existing one the indentation is not there anymore. Setting to NW because of that.
@mitthukumawat, thanks for the screenshots. They should be placed in the Issue Summary in the 'user interface changes section'. If that is not there then add the template and then add the screenshots.
@chetanbharambe, Adding screenshots that a patch applied or more screenshots based on the same patch as has added already done does not advance the issue. Removing credit per How is credit granted for Drupal core issues.. The contributor guide on Drupal.org has information about how to contribute, particularly the process to Review a patch or merge request.