Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
23 Jun 2022 at 12:02 UTC
Updated:
23 Dec 2022 at 10:14 UTC
Jump to comment: Most recent
Assorted todo lists carried over from #3259739: [meta] Priorities for 2022-06-01 release of Drupal 7.
These are not necessarily in priority order.
Top priorities
- #3224299: [META] Make Drupal 7 core compatible with PHP 8.1
- #3304807: [META] Make Drupal 7 compatible with PHP 8.2
- #3284269: Fix samesite attribute on Drupal.toolbar.collapsed and other similar cookies
- #3292743: Remove FLoC header from D7 as google has abandoned it
- #3293648: [D7 backport] Update status does not verify the identity or authenticity of the release history URL
- #3310081: javascript links in contrib broken since 7.92
For consideration
- #3071997: Backport to D7 - inclusion of the announce project in D7 core - see also:
- #3206643: Project messaging channel in core (as experimental) and linked issues
Issues which have had recent activity, and are RTBC.
Simple Fixes:
- #674354: CSS selectors get overridden by narrower selector at style.css when using Seven Simple fix, moves inline with D8 having more specific selectors.
- #2492191: Remove "Crawl-delay" in robots.txt Simple fix. For parity with D8/9 this should probably be committed to D7 although taking this out of D7 now seems like a big change at such a late stage; users who want to change Crawl-delay will already have done this. The patch itself is trivial so marking RTBC for a D7 core committer to decide whether to commit or close this.
- #2871459: Simpletest does not reset the $theme* globals
- #3026560: After upgrade to 7.63, 8.5.10, 8.6.7, 9.4.0 get TYPO3 phar error for drush
- #3255713: [D7] Login fails and no warning is issued if cookies are not enabled This is a D7 backport of #2946: Login fails and no warning is issued if cookies are not enabled, an 18 year old issue that was marked as major and committed to drupal 9.3.x in June 2021.
- #3308929: [D7] Cron lock time limit is too short and does not prevent multiple, concurrent cron runs
- #1281732: Fatal error when taxonomy_options_list() tries to call an undefined callback function
- #753898: Wrong message for blocked users who request password reset
- #3085861: Fix typos in simpletest comments
- #3101859: Remove redundant return statements
- #2903330: Documentation page for hook_field_storage_info_alter() contain a reference to hook_field_field_storage_info()
- #2397691: Random fail in Drupal\taxonomy\Tests\TermTest::testNodeTermCreationAndDeletion()
- #2901466: Comment in field_default_form() is missing a "not", inverting its statement
- #1504544: Strict warning: Only variables should be passed by reference in run-tests.sh
- #2956127: Use cronRun() in tests
- #2554965: hook_comment_unpublish is never invoked
- #512042: Add user action "unblock current user" to user.module
- #2927466: "Conflicting" validators for user picture leads to confusing form error message
- #2248177: Image dimensions should accept only positive values
- #2070807: book_node_load() ignores the 'book_allowed_types' and does excessive SQL queries
- #3308471: [D7] Update CommonXssUnitTest::testBadProtocolStripping() to check other allowed / dangerous protocols
- #1470236: Array flip error when a taxonomy term field has a NULL value
- #1821178: Performance tune text_field_load()
- #1565892: node_type_delete() doesn't check the value returned from node_type_get_type()
- #3015142: drupal_goto short circuits and doesn't set things to cache
- #2692099: Autocomplete search 'finds' wrongly for strings with white space
Important Fixes:
- #2749007: Autocomplete broken for servers enforcing clean URLs Security Regression
- #1705618: Double click prevention on form submission Important to prevent double submission of forms, creating duplicate nodes, etc. Must clear browser cache to take effect.
- #1899126: [D7] Add wrappers to fix permission checks Required for POSIX filesystem. Fixed in D8? @orlitzky: "I'm just going to keep updating the patch for drupal-7.x for the rest of my life." "I'll keep posting patches until I don't have to any more."
- #1951408: Core Update manager doesn't correctly handle "status" UPDATE_NOT_CHECKED Includes D7 core patch in comment #16 that passes tests and is RTBC. Required for update_advanced module that is used by 2,700 sites. Does not appear to be relevant to D8/D9.
- #1978176: Build menu_tree without loading so many objects @joseph.olstad: "... the performance improvement is huge! .. After several years I see no credible reports of an issue with this patch"
- #2418755: Path alias filter by system path (D9 patch, still Needs review) includes 6 year old patch for D7 in comment #1 that has been RTBC and without the patch "it's very hard to find alias which contains few slashes in path."
- #2550519: Crypt::randomBytes()/drupal_random_bytes() doesn't actually return cryptographically secure random bytes Issue is 6 years old, priority was set as "critical", still needs work.
- #2752783: [D7] file_unmanaged_move() should issue rename() where possible instead of copy() & unlink() Important fix. Mcdruid urging commit. @joseph.olstad: "D8 has this already. It is a good idea."
- #2783153: [D7] Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future FabianX said it looks good, has updated tests
- #2891346: tableheader.js: Source: call to eval() or related function blocked by CSP Another content-security-policy issue.
- #2970929: [D7] Support X-Forwarded-* HTTP headers alternates Important backport for reverse proxies and load balance.
- #3176634: [D7] node_access filters out accessible nodes when node is left joined Issue identified as major. D8/9 fix pending.
- #2539478: [D7] Allow image fields to use any extensions the current image toolkit supports (instead of hard-coding jpg, png and gif only) Remove hardcoded image files extensions.
- #3210388: Potential dataloss when opting in to "Avoid field storage write when field content did not change" and changing the bundle type of an existing entity
- #2925487: svg element is rendered broken in Full HTML format
- #2966195: valid_email_address() should be easily overridable
- #3306390: [D7] Changing email address should invalidate one-time login links
Unsorted Fixes:
- #3284424: pg_attribute.attrelid error
- #498752: Partial word search for Drupal 7 Includes working patch from 5 yrs ago. Was closed as won't fix feature request. Now that a similar feature is proposed for D9 core #103548: Partial Search in Drupal Core maybe it's worth considering.
- #111702: Set fixed "from:" and add "Reply-to:" to comply with DMARC
- #965078: HTTP request checking is unreliable and should be removed in favor of watchdog() calls Needs work and needs CR
- #1328696: Problem with _drupal_wrap_mail_line and attachment files Attachment of docx file or files with long names results in email that is not correct. Fixed in D8, backport for D7 has patch.
- #3017522: Make SSL options configurable in drupal_http_request() Verifies SSL certificates in OpenSSL connections (Critical)
- #139015: breadcrumbs wrong on dblog event detail pages Issue seems in good shape, needs a bit of work as of Aug-4
- #691932: Add hook_field_schema_alter()
- #1992010: Reverting to revisions prior to addition of field translations is broken Issue is 9 years old, marked as critical and has patch that is RTBC and passes automated tests. Are tests sufficient?
- #1158322: Add backtrace to all errors
- #3035571: [D7] ImageStyle::transformDimensions unable to deal with all effects.
- #1982810: Core entity_get_controller gets a NULL controller class
- #3304385: [D7] node/add page misses content types when menu links are moved or disabled
- #2060235: Getting a PDOException when adding new image style named thumbnail, medium and large
- #3007538: Cron.php does not check for maintenance mode correctly
- #1621334: Notice: Undefined property: stdClass::$forum_tid in forum_node_view()
- #2847484: Support boolean attributes in drupal_attributes()
- #2962374: [D7] Path alias validation should test for relative path, no trailing slash requirements
- #2456193: Menu links - not possible to create numeric paths
- #2793297: [D7] Automatically shorten cid's in DrupalDatabaseCache
- #2177335: Selecting 'Disabled' does not move the block to the disabled region when there are no disabled blocks
- #1451072: Deleting a comment author while the Comment module is disabled leads to an EntityMalformedException error after it's reenabled
- #2978218: Add "delete" link on node Translate tab Operations
Comments
Comment #2
longwave#3292211: Seven theme fieldset-legend not clickable in Chrome 103.0.5060.53 might be important.
Comment #3
mcdruid commentedComment #4
mcdruid commentedThanks @longwave, have added that and another postgres issue I was pinged about.
Comment #5
mcdruid commentedAdded #3292743: Remove FLoC header from D7 as google has abandoned it (the D9 issue is RTBC but not yet committed).
Comment #6
mcdruid commentedAdded two new security hardening issues filed by @longwave. Thanks!
Comment #7
poker10 commentedAdding some simple RTBC/NR issues I have checked and which seems to be pretty ready in my opinion.
#2319177: Cron lock time limit is too short and does not prevent multiple, concurrent cron runs
#2021571: preview of menu machine name is inaccurate on while adding a menu (does not show it will be saved with menu- prefix)
#2772107: UNION queries don't support ORDER BY clauses
#2644276: Mixed case taxonomy terms not loaded from the internal entity cache
#1327224: Access denied to taxonomy term image
#2779833: Fix Drupal 7 .htaccess to protect .orig and .save files from view
#3004215: Method DatabaseCondition::__toString() must return a string value
#2669254: PDOException when calling locale_add_language() with $enabled = FALSE
#3064734: DatabaseStatementPrefetch::current PHP function array_unshift() are used incorrectly
#3138348: system_batch_page() should call drupal_exit() after drupal_access_denied()
#920840: Broken images displayed and PHP notices when file/image field values are missing
Comment #8
anthonyroundtree commentedIs the following ready to be added
Administration theme CSS causes crash in CK Editor plugins (and Chrome browser crash)
Comment #9
poker10 commented@anthonyroundtree This is a meta issue for Drupal 7 planned release. That linked issue seems to be a Drupal 9 issue and contains no info whether that behavior is a problem also in Drupal 7.
Comment #10
poker10 commentedAdded few more simple issues, which I have checked and which seems to be in a good shape (RTBC/NR, has tests and seems good). Also removed one issue from the list which was D9 issue (without any D7 presence).
Comment #11
poker10 commentedUpdated the comment on #3176634, the D8/9 issue was not committed until now.
Comment #12
poker10 commentedAdding PHP 8.2 compatibility issue here (in December, the PHP 8.2 will be already released).
Comment #13
poker10 commentedAdding few more simple issues (RTBC/NR, which should be pretty ready too). Also removed one issue from the list because it is D9 issue and needs to be fixed here first (we can add a follow-up issue here after that).
Comment #14
poker10 commentedRemoving issues already commited and released in Drupal 7.92 (these issues were moved here: #3306877: [meta] Priorities for 2022-09-07 release of Drupal 7).
Comment #15
poker10 commentedAdding some additional issues to consider/review.
Comment #16
ressaFixing the mark up.
Comment #17
ressaRestoring indentation for "#3206643: Project messaging channel ...", I missed the colon at the end :-)
Comment #18
ressaFixing new
</il>...Comment #19
mustanggb commentedComment #20
mcdruid commented@poker10 and I have agreed we'll start a (short) commit freeze now in anticipation of the release in a couple of days (Wed 7th Dec).
Here are the provisional release notes, without the section we usually add at the top listing all CRs (generated via drush grn):
Changes since 7.92:
Comment #21
mcdruid commentedhttps://www.drupal.org/project/drupal/releases/7.93 was released today as planned.
Thank you everyone that contributed!
We'll spin up a new meta issue and carry over open issues we still want to work on for the next release scheduled for 2023-06-07.
Comment #22
long.skinny.boy commentedThank you for still supporting version 7!
And why hasn't the version of the translation files caught up with the current core version yet? (https://localize.drupal.org/download)
While still 7.92