first selector at dblog.css & dblog-rtl.css are specific for type and severity <select> filters
when using Seven, its style.css gets a narrower selector div.form-item braking the styling of dblog module
instead of .form-item-type, .form-item-severity {
it should read one of the following:
- #dblog-filter-form .form-item-type, #dblog-filter-form .form-item-severity {
- #dblog-filter-form .form-type-select {
- #dblog-filter-form .form-item {
| Comment | File | Size | Author |
|---|---|---|---|
| #24 | 10_year_wait_for_this_fix.jpeg | 10.54 KB | joseph.olstad |
| #23 | 674354-23.patch | 868 bytes | joseph.olstad |
| #7 | Garland-before-patch.jpg | 6.4 KB | arhak |
| #7 | Seven-before-patch.jpg | 6.85 KB | arhak |
| #7 | Garland-after-patch.jpg | 6.4 KB | arhak |
Comments
Comment #1
arhak commentedNote that the three solutions suggested above go from more specific to more generic and all of them currently work properly with Seven and Garland
Nevertheless, I suggest not to consider the first one, since it is too specific and a more generic case might fit in, like considering others filters getting in #582622: provide hook for dblog_filters
(which that patch's testing was how this issue arose)
Comment #2
arhak commentedComment #3
wretched sinner - saved by grace commentedThere are two obvious ways to resolve this - the first as suggested by the original post. The second, however would be a more major change, that of removing all the unnecessary tag selectors. This would be the best option for speed as per http://code.google.com/speed/page-speed/docs/rendering.html
Before rushing too far into it, is it worth having this debate so close to D7 alpha?
Comment #4
arhak commented@#3
the first option is just to fix a bug "ala D6", resulting in consistent behavior between current D7 administrative themes: Garland (which currently works for D7) and Seven (which currently doesn't get these styles and <select> lists tight together without any margin/padding)
the second option would be "a more major change" which shouldn't get started to be explored/tested/debated "so close to D7 alpha"
Comment #5
arhak commentedalso note, that currently (today's D7)
dblog.csshas the following firsts rules:the 2nd and 3rd rules are targeting
#dblog-filter-form .form-???what I suggest to fix the bug that arises with Seven is to use the same "id selector" for the 1st rule
Comment #6
wretched sinner - saved by grace commentedThe attached patch takes the first option, since this is more consistent with the other definitions in
dblog.cssComment #7
arhak commentedtested OK with D7 tarball (2010-Jan-05)
attached before/after patch images for Garland & Seven
Comment #8
arhak commentedI would recommend considering CSS patch attached to #582622-49: provide hook for dblog_filters
(it is over there for testing that other issue, but seems more flexible/accurate)
Comment #9
klonossubscribing...
Comment #10
droplet commentedcode standard issue
Comment #11
tadityar commentedD8 already have more specific selectors. Moving back to D7
Comment #12
tadityar commentedComment #13
tadityar commented^ is a re-roll of 6
Comment #14
studiozut commented12 works for me
Comment #15
polThe patch is fine and does the job.
Comment #16
joseph.olstadBumping to 7.61, this didn't make it into 7.60
Comment #17
joseph.olstadComment #18
joseph.olstadComment #19
mustanggb commentedComment #20
mustanggb commentedComment #21
arhak commenteduhh, 10 years for such a tiny patch...
Comment #22
arhak commentedbe aware of re-roll typo: missing space
+#dblog-filter-form.form-item-severityComment #23
joseph.olstadfixed the re-roll regression
still RTBC
Comment #24
joseph.olstad*EDIT* lets get this patch in.
Comment #25
neslee canil pinto@joseph.olstad , #24 describes the 10 years journey.
Comment #27
dagmarBack to RBTC
Comment #28
dagmarComment #30
mcdruid commentedThank you for your patience!