first selector at dblog.css & dblog-rtl.css are specific for type and severity <select> filters

when using Seven, its style.css gets a narrower selector div.form-item braking the styling of dblog module

instead of .form-item-type, .form-item-severity {
it should read one of the following:
- #dblog-filter-form .form-item-type, #dblog-filter-form .form-item-severity {
- #dblog-filter-form .form-type-select {
- #dblog-filter-form .form-item {

Comments

arhak’s picture

Note that the three solutions suggested above go from more specific to more generic and all of them currently work properly with Seven and Garland
Nevertheless, I suggest not to consider the first one, since it is too specific and a more generic case might fit in, like considering others filters getting in #582622: provide hook for dblog_filters
(which that patch's testing was how this issue arose)

arhak’s picture

Status: Active » Needs review
Issue tags: +Quick fix
wretched sinner - saved by grace’s picture

There are two obvious ways to resolve this - the first as suggested by the original post. The second, however would be a more major change, that of removing all the unnecessary tag selectors. This would be the best option for speed as per http://code.google.com/speed/page-speed/docs/rendering.html

Before rushing too far into it, is it worth having this debate so close to D7 alpha?

arhak’s picture

@#3
the first option is just to fix a bug "ala D6", resulting in consistent behavior between current D7 administrative themes: Garland (which currently works for D7) and Seven (which currently doesn't get these styles and <select> lists tight together without any margin/padding)

the second option would be "a more major change" which shouldn't get started to be explored/tested/debated "so close to D7 alpha"

arhak’s picture

also note, that currently (today's D7) dblog.css has the following firsts rules:

.form-item-type, .form-item-severity {
  float: left; /* LTR */
  padding-right: .8em; /* LTR */
  margin: 0.1em;
  width: 15em;
}
#dblog-filter-form .form-type-select select {
  width: 100%;
}
#dblog-filter-form .form-actions {
  float: left;
  padding: 3ex 0 0 1em;
}

the 2nd and 3rd rules are targeting #dblog-filter-form .form-???
what I suggest to fix the bug that arises with Seven is to use the same "id selector" for the 1st rule

wretched sinner - saved by grace’s picture

StatusFileSize
new740 bytes

The attached patch takes the first option, since this is more consistent with the other definitions in dblog.css

arhak’s picture

StatusFileSize
new7.06 KB
new6.4 KB
new6.85 KB
new6.4 KB

tested OK with D7 tarball (2010-Jan-05)

patching file `modules/dblog/dblog-rtl.css'
Hunk #1 succeeded at 1 with fuzz 2.
patching file `modules/dblog/dblog.css'
Hunk #1 succeeded at 1 with fuzz 2.

attached before/after patch images for Garland & Seven

arhak’s picture

I would recommend considering CSS patch attached to #582622-49: provide hook for dblog_filters
(it is over there for testing that other issue, but seems more flexible/accurate)

klonos’s picture

Title: CSS selectors get overrode by narrower selector at style.css when using Seven » CSS selectors get overridden by narrower selector at style.css when using Seven

subscribing...

droplet’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs review » Needs work
Issue tags: +Needs backport to D7

code standard issue

tadityar’s picture

Version: 8.0.x-dev » 7.x-dev
Issue summary: View changes

D8 already have more specific selectors. Moving back to D7

tadityar’s picture

Status: Needs work » Needs review
StatusFileSize
new855 bytes
tadityar’s picture

^ is a re-roll of 6

studiozut’s picture

12 works for me

pol’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs backport to D7 +Drupal 7.60 target

The patch is fine and does the job.

joseph.olstad’s picture

Issue tags: -Drupal 7.60 target +Drupal 7.61 target

Bumping to 7.61, this didn't make it into 7.60

joseph.olstad’s picture

joseph.olstad’s picture

mustanggb’s picture

Issue tags: -Drupal 7.64 target +Drupal 7.69 target
mustanggb’s picture

Issue tags: -Drupal 7.69 target +Drupal 7.70 target
arhak’s picture

uhh, 10 years for such a tiny patch...

arhak’s picture

be aware of re-roll typo: missing space
+#dblog-filter-form.form-item-severity

joseph.olstad’s picture

StatusFileSize
new868 bytes

fixed the re-roll regression
still RTBC

joseph.olstad’s picture

StatusFileSize
new10.54 KB

*EDIT* lets get this patch in.

neslee canil pinto’s picture

@joseph.olstad , #24 describes the 10 years journey.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 23: 674354-23.patch, failed testing. View results

dagmar’s picture

Status: Needs work » Reviewed & tested by the community

Back to RBTC

dagmar’s picture

  • mcdruid committed 77124b4 on 7.x
    Issue #674354 by joseph.olstad, tadityar, wretched sinner - saved by...
mcdruid’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -Drupal 7.74 target

Thank you for your patience!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.