[D8] Media entity Pinterest

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi bonus,

Git errors:

• Git default branch is not set, see the documentation on setting a default branch.

Review of the 8.x-1.x branch (commit 9beb3ad):

• Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  
  FILE: /root/repos/pareviewsh/pareview_temp/README.md
  ----------------------------------------------------------------------
  FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
  ----------------------------------------------------------------------
   15 | WARNING | Line exceeds 80 characters; contains 102 characters
   22 | WARNING | Line exceeds 80 characters; contains 84 characters
   31 | WARNING | Line exceeds 80 characters; contains 107 characters
   33 | WARNING | Line exceeds 80 characters; contains 94 characters
  ----------------------------------------------------------------------
  
  Time: 166ms; Memory: 8Mb
  

• ESLint has found some issues with your code (please check the JavaScript coding standards).
  

  /root/repos/pareviewsh/pareview_temp/js/pinterest.js: line 7, col 3, Error - Strings must use singlequote. (quotes)
  
  1 problem
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Recommendations :

• It is recommended that you include hook_help in your .module file. That would help users to understand better.
• You can provided detail instructions on your application page so that its easier for other reviewers.
• Also, If there are similar modules add it to your application and mention the difference which your module provides. This would help reviewer to understand the need of the module better.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Hi bonus,

Thanks for contrib this module, I have found the issue which is as below

1. In the below file you are direction using the $matches[0], $matches[1], so in place of directing using the array indexing you should first check those index are set in the array or not because this will cause the php error if the array is not set check the below code.
FileName: src/Plugin/Field/FieldFormatter/PinterestEmbedFormatter.php
Below Code
// PIN_URL_RE matched.
if (!empty($matches['id'])) {
$element[$delta] = [
'#theme' => 'media_entity_pinterest_pin',
'#path' => 'https://' . $matches[2] . 'pinterest.' . $matches[3] . $matches[4] . '/pin/' . $matches['id'],
'#attributes' => [
'class' => [],
'data-conversation' => 'none',
'lang' => $langcode,
],
];
}

2 And I have found one issue in the parview also so please check this and please use the drupal as a prefixed in the info.yml check the attached screen shot.

pareview shows now this error: There is a git tag that has the same name as the branch 8.x-2.x. Make sure to remove this tag to avoid confusion.

8.x-1.x: x in module version is only allowed for branches.
Tags should have a numbered module version after the core version like 8.x-1.0-beta1 .

8.x-2.x-beta3 and 8.x-1.x-beta3: replace 2.x and 1.x with 2.0 and 1.0: 8.x-2.0-beta3 and 8.x-1.0-beta3

Automated Review

Review of the 8.x-1.x branch (commit 91ffed4):

• Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
  • The INTRODUCTION section is missing.
  • The REQUIREMENTS section is missing.
  • The INSTALLATION section is missing.
  • The CONFIGURATION section is missing.
• The media_entity_pinterest.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

1. (*) The media_entity_pinterest.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

@bonus , I do not agree with your argumentation concerning the old style README. Just because others do not follow the recent rules, it is not the best argument to do the same.

Thank you for your contribution!

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.