[D7] Way2SMS (Send SMS | Rules Integration)

Git clone command for the sandbox is missing in the issue summary, please add it.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review:

Review of the 7.x-1.x branch (commit 6f24cee):

• No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

Link to automated review results can be found here

Manual Review:

1. Dependencies should be namespaced to the project they are part of, in the format: dependencies[] = {project}:{module}
2. You can also add a hook_install which might simply display a note confirming that the module is installed or you can provide link to configuration page. See here.
3. Defining "package" isn't good as it is a single module. See here.
4. It is good to use tag reference content.
5. A very little small typo is there: 'group' => t('Wasy2SMS') should be 'group' => t('Way2SMS')
6. It is recommended to add a watchdog message if sms has been successfully sent.

Negative Test Case

Receiver Phone number is text or token of rules

drupal_set_message(t("Invalid Contact Number: @num", ['@num' => $contact_number]), 'error');
will return number. I think it should be more smart in this case.

SMS is still being sent (not actually)

$reciever_contact_field = _way2sms_preprocess_contact_field($reciever_contact_field);
Actually, after this line: $reciever_contact_field = FALSE and this $result = $client->send($reciever_contact_field, $message); won't check if the $reciever_contact_field is a number or not.

@kajalkiran

It is recommended to add a watchdog message if sms has been successfully sent.

It's a good thing to let the user/admin know whether the message has been successfully sent :) I am not sure, but we already has error messages in place for

Watchdog message set on when message is not sent.

This is not that necessary, but it's good, so I am not changing the status to needs work. I am reviewing it again.

So, finally it works good as of now ! We can add certain features later on. Issuing RTBC. :)
@kajalkiran Nice work !! Having a rules integration is awesome!

I am changing status to Needs Review, let it be reviewed by few more people ;)

manual review:

1. project page: could you add the differences to other projects to your project page also?
2. _way2sms_send(): @return should have the data type after it, see https://www.drupal.org/docs/develop/coding-standards/api-documentation-a...
3. _way2sms_send(): the watchdog() logs could be more helpful with using placeholders for the error returned in the result or for the message or the phone number.
4. _way2sms_login(): the function_exists() call is not necessary here. You depend on the libraries module, which muss be enabled before your module is enabled.
5. way2sms_rules_action_info(): The "$" in the parameter names for the Rules action should be removed, parameter names should only contain a-z letter and under scores.

Otherwise looks good to me.

Thanks for your contribution, Kajal!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.