[D7] Closed Question Disable Loading

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxrekcor2504499git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

1. Git errors:

There is still a master branch, make sure to set the correct default branch: https://www.drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in https://www.drupal.org/node/1127732

@koosvdkolk ,

If you are the main maintainer, why created a new project ? I think that would be better to add it as sub-theme submodule ?

I do not understand the difference between Git submodule or a Drupal submodule. To me they are the same, correct me if I'm wrong. I would explain in details what I mean by creating a sub-module with two examples:

1. Some modules such as Metatag module contain sub-modules with in the same project to extended the project functionality. Look at this picture below that show all the module that the project Metatag contain, and all is doing extending the project (module) functionality. If every single module would be a different project to configure the metatag module would be a mess.
   
2. Another example is the mobile_detect module, this module had a caching problem #1889824: Drupal Cache + Mobile Detect Conflict. So, the maintainer fix this problem by creating another module and added into same project.
   

Why ?

• Sub-module would be easier for the user to download.
• Mostly likely the user would find about this once he download it the main project.
• The project will grow as ecosystem around couple module, which I think personally would make the project better.

All these are personal opinions, which you should consider; however, they are not required.

Looks good to me. All problems are solved.

@timcooijmans, you need to provide a full review before change it to RCTB. For future review see PAReview: Review Template.

@koosvdkolk, since this been so long and nobody have done a review on your project, I'm assign to my self to do a complete review.

Fixed the git clone URL in the issue summary for non-maintainer users.

I'm a robot and this is an automated message from Project Applications Scraper.

Corrected git clone command in issue summary to refer to correct branch.

Also, six months has passed since darol100 assigned himself to do a full review. Since he hasn't followed up on the committment, I've unassigned it - so that others can have a go.

Please note that assigning an issue to yourself is problematic for several reasons. For background, please see this page.

Automated Review

PAReview object to a comment that is not a comment but commented out code line. Don't leave such cruft in your code. However, deleting this line is trivial and not a requirement for getting through the application process.

Manual Review

Individual user account

Yes: Follows the guidelines for individual user accounts.

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md

Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

No issues found.
The starred items (*) are big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are release blockers and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

Conclusion

There are IMHO no more blockers. Moving to RTBC. Note that promotion will not happen until a git administrator has given this a second set of eyeballs.

Is there anything on my behalf to speed up the process?

Yes.

Join the Review bonus system and earn a review bonus.

From my point of view,, one of the best ways to learn best practice, is too review others - then you learn what is best practice or not, anyhow:

Thanks for your contribution, koosvdkolk!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.