[D7] Da vinci

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxnguerrero2385135git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

Solve the issues at: http://pareview.sh/pareview/httpgitdrupalorgsandboxnguerrero2385135git

Manual Review

Individual user account

Yes: Follows

No duplication

Yes: Does not cause module duplication and/or fragmentation.

Master Branch

Yes: Follows the guidelines for master branch.

Licensing

Yes: Follows the licensing requirements.

3rd party assets/code

Yes: Follows mthe guidelines for 3rd party assets/code.

README.txt/README.md

No: Does not follow the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review

Yes: Follows the guidelines for project length and complexity.

Secure code

Yes: Meets the security requirements.

Coding style & Drupal API usage

Looking Okay

Hi nguerrero,

Firstly good job, i reviewed your theme and following were my findings:
1) The node edit menu overlaps the right side bar when there are lot of links.

2) The footer overlaps the page content after a certain limit.

3) In the Right side bar, blocks are not having enough space between them.

4) The main menu is little shaky on click.

Review of the 7.x-1.x branch (commit 45cb252):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. there is a git branch "7.0" which should be deleted to avoid confusion.
2. da_vinci_status_messages(): this is a theme override, so doc block should be "Implements theme_status_messages().". Same for da_vinci_breadcrumb() and others.
3. da_vinci_page_alter(): since you are not altering the page but only adding stuff you should use hook_page_build(), right?
4. da_vinci_preprocess_html(): using arg() here seems wrong - why do you add page specific classes to the html template? Shouldn't that be the page template?
5. js/plugins: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

The inclusion of the third party libraries is a blocker right now.

Not able to do a git clone :( Is that the git clone link http://git.drupal.org/sandbox/nguerrero/2385135.git ?

It gives a error "unable to access".

Removed reviews that did not review the source code.

Review of the 7.x-1.x branch (commit 9d07ab4):

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

• custom.js: @file comment is confusing. What custom output? What does the function do?

But otherwise looks good to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to sreynen as he might have time to take a final look at this.

Hi nguerrero, Thanks for the contribution. I have done some manual testing and found some bugs. Please check screenshots for reference.

• Comments section seems like breaking.
• Site footer is wrongly positioned, Please check screenshots.
• Messages are fixed positioned, Please remove that.
• Sidebar content disappear due to footer position.

@Manjit.Singh: Those look like minor bugs but surely not application blockers, anything else that you found or should this stay RTBC?

@klausi Yeah There is no application blockers i found :) Stay it in RTBC.

No other objections for more than a week, so ...

Thanks for your contribution, nguerrero!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Thanks for Contribution , nguerrero !!