WordPress Passwords

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxselexin2384473git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

> core = 7.x`

Stray backtick.

> * Implementation of hook_form_alter()

It's more efficient here to use hook_form_FORM_ID_alter(). Though.... I seem to remember the user login page and block have different form IDs?

/*
 * Implementation of hook_form_alter()
 */

Docblock formatting is incorrect -- missing *

Same here, and lines need wrapping:

/*
 * Validation handler for user login form.
 *   Converts password from wordpress hash (if found) to Drupal hash during the validation process, so that the password is already
 *   stored as a Drupal hash during the submit process (allowing uninterupted first-time login by the user)
 */

Further coding standards issues -- the automated review should have picked them up.

Other than that, looks ok, though I don't know enough to comment on this:

			if(substr($loaded_user->pass, 0, 3) == '$P$') { //not the best way to consider a password is from WordPress. I'm welcome to other suggestions.

It would be nice if could not translate the link as it is now.
You could encapsulate the text if it must be translated with the t() function which then do not drupal_set_message ($error), 'warning');

Maybe?

function wordpress_passwords_enable() {
  if (!file_exists(WORDPRESS_PASSWORDS_WP_CLASS)) {
    $error = t("Could not find class-phpass.php. Please read for installation instructions:");
    $error .= "<a href='" . drupal_get_path('module', 'wordpress_passwords'); . "/README.txt>README.txt</a>";
    drupal_set_message(($error), 'warning');
  }
}

simplytest.me/project/2384473

I have not found error message about not having the class-phpass.php in includes directory.

    $error .= "<a href='" . drupal_get_path('module', 'wordpress_passwords'); . "/README.txt>README.txt</a>";
    drupal_set_message(($error), 'warning');

This won't be translatable.

> * Install file for wordpress_passwords.

This file is in the wrong place, and core probably won't find it. It should be in the same folder as the .info and the module file.

> Install Instructions: Download class-phpass.php from
https://raw.githubusercontent.com/WordPress/WordPress/3.8-branch/wp-incl...
to the folder 'includes' inside this module directory

That's not a recommended way to do things -- when users upgrade your module, they'll clobber that file and have to download it all over again. Use Libraries module to declare the WP file as a required PHP library, and hook_requirements() to only allow your module to be enabled when it's present (rather than hook_enable()).

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 93 characters

Make the character count less that 80 for remove error from http://pareview.sh/pareview/httpgitdrupalorgsandboxselexin2384473git

Hit enter after some character is the solution.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.